feat: add support to configure controller jbod mode

Naudit / pystorcli2

Python library provides wrapper around storcli tool to manage and control LSI MegaRAID controllers.

BSD 3-Clause "New" or "Revised" License

2 stars 7 forks source link

feat: add support to configure controller jbod mode #19

Closed dgilbert101 closed 5 months ago

dgilbert101 commented 5 months ago

Needed the ability to disable/enable jbod mode on controllers that support it. Add the simple functionality to disable or enable it.

coveralls commented 5 months ago

coverage: 61.359% (+0.02%) from 61.34% when pulling dcdd68e3048c9c01ec8a0ff7ddb31c048b3f7022 on liveaction:develop into c9cfcecd15317f77abc89fdacf273afb02157f9f on Naudit:develop.

ralequi commented 5 months ago

Hi @dgilbert101 !

Thanks for your contrib. However, I have a few questions:

Don't you think true/false would be greater option rather than on/off?
Why do you think that would be better than a boolean attribute?
Could you explain your motivations for an str instead of bool type please?

dgilbert101 commented 5 months ago

I'm not opposed to true/false, although nothing else is true/false. So the current syntax keeps with the existing nature of the interface.

ralequi commented 5 months ago

Good point.

I really dislike keeping something binary as text. So, I would accept this as is, and change into true/false in the future as the other API.

Thanks again for your contrib!

dgilbert101 commented 5 months ago

Sounds good.