Nano -> Banano wording - Githubissues

Nault / Nault

⚡ The most advanced Nano wallet with focus on security, speed and robustness

https://nault.cc

MIT License

268 stars 83 forks source link

Nano -> Banano wording #81

Open sebrock opened 4 years ago

sebrock commented 4 years ago

All instances of the 'Nano' wording should be replaced with 'Banano'

(PENDING agreement for location and handling of Banano specific components)

Wording change tracking for modules: (tick if you have completed one) Ideally done in the same step as the first 2 activities in #85

[ ] account-details
[ ] accounts
[ ] address-book
[ ] change-rep-widget
[ ] configure-app
[ ] configure-wallet
[ ] helpers
[ ] import-address-book
[ ] import-wallet
[ ] manage-representatives
[ ] manage-wallet
[ ] notifications
[ ] qr-scan
[ ] receive
[ ] representatives
[ ] send
[ ] sweeper
[ ] transaction-details
[ ] wallet-widget

Any donation addresses should be changed (TBD)

BitDesert commented 4 years ago

This should be done dynamically by the environment file.

My1 commented 4 years ago

wait is nano in nault gonna die? because at least according to read me this is supposed to be a nano wallet, not banano

sebrock commented 4 years ago

wait is nano in nault gonna die? because at least according to read me this is supposed to be a nano wallet, not banano

There will be a Banano version of Nault. Sharing code base and configurable builds for both.

My1 commented 4 years ago

I see. the issue kinda sounded a lot more like to ax nano completely:

"All instances of the 'Nano' wording should be replaced with 'Banano'"

sebrock commented 4 years ago

I see. the issue kinda sounded a lot more like to ax nano completely:

"All instances of the 'Nano' wording should be replaced with 'Banano'"

The issues were originally created in another repo, where the plan was to adapt Nault to a Banano-only version. With the new approach of a shared codebase this certainly sounds weird to the outside world.