search

NavidK0 / Carbon

Carbon is a Spigot plugin which turns a spigot protocol hacked server (on 1.7.10) into a 1.8 server.
GNU Lesser General Public License v3.0
35 stars 19 forks source link

[Bug] Torch light only affects block hanging/standing on when unloading and reloading the chunk. #10

Closed mibby closed 10 years ago

mibby commented 10 years ago

See comments here. https://github.com/NavidK0/Carbon/commit/8d241f20f1ed6a37b8d47d14529e41b5c0e96130

Shevchik commented 10 years ago

Should be fixed. Somebody used wrong name for unlit redstone torch. Or maybe it's the new injection method fixed it.

mibby commented 10 years ago

Great, I'll recompile and double check. :) Do you want to reinject torches now? https://github.com/NavidK0/Carbon/commit/c6b8381d4dbb053d2121378d947b1768c93b90ca

Edit: Nevermind. I see they are re-injected.

Shevchik commented 10 years ago

Heh, looks like it stopped working for some reason again >_<

mibby commented 10 years ago

Ah, darn. I shall wait then.

Shevchik commented 10 years ago

Looks like i nailed it. Still don't know why it is like that.

mibby commented 10 years ago

Great, I'll double check to verify it is fixed.

Shevchik commented 10 years ago

So i found it, i's the method a(float) int Block which controls block light level. Should be able to apply light level to sea lantern now.

mibby commented 10 years ago

And that would fix torches properly? Or would it be used to introduce light levels into sea lanterns?

Notice the edit. Sounds great! Looking forward to sea lantern fix.

Shevchik commented 10 years ago

Already

mibby commented 10 years ago

Haha, thanks. You're fast. :P Updating again to verify. Will close tickets once verified.

mibby commented 10 years ago

Torches confirmed fixed per this commit. https://github.com/NavidK0/Carbon/commit/7113dd0e4127206f3dff7c83b141f62b509028cc

Old torches need to be placed again to update the block light levels, but new torches are correctly saving when unloading the chunk and reloading it.