Closed johanhelsing closed 2 years ago
Done with https://github.com/LastAbyss/SimpleGraphQL-For-Unity/commit/1e987605ca452ec62dd142b36a26b8f208257819
I think we are starting to reach the point where we may want to use a configuration object parameter (similar to JavaScript), instead of many parameters.
Perhaps something like SendRequestSettings
or similar.
I think that API could look like
var result = await apiClient.Send(
() => new { result = resultTypeResolver() },
request,
new {
Token = token,
Scheme = scheme
}
);
After upgrading, my project stopped working due to this change:
https://github.com/LastAbyss/SimpleGraphQL-For-Unity/commit/b4a473becf9d0558d1b103dddc1826c23a81f582
The code that stopped building
We should probably either bump major version or restore an overload with the old api, or move the settings arg so it's the last overload.