Improve native error handling

Type

enhancement, bug_fix

Description

Added a new function parseGattErrorCode in Kotlin to map GATT status codes to human-readable error messages.
Enhanced error handling in Android and iOS by utilizing the new error parsing and conversion methods for BLE operations.
On Android, onCharacteristicRead and onCharacteristicWrite now provide detailed error messages using GATT status codes.
On iOS, added an extension to convert errors to FlutterError, improving the error messages in BLE operations.

Changes walkthrough

Relevant files

Enhancement

UniversalBleHelper.kt `Add GATT Error Code Parsing` android/src/main/kotlin/com/navideck/universal_ble/UniversalBleHelper.kt Added `parseGattErrorCode` function to map GATT status codes to error messages.	+27/-0
UniversalBlePlugin.kt `Use GATT Error Codes for Detailed Error Messages` android/src/main/kotlin/com/navideck/universal_ble/UniversalBlePlugin.kt Modified `onCharacteristicRead` and `onCharacteristicWrite` to use `parseGattErrorCode` for detailed error messages.	+17/-4
UniversalBleHelper.swift `Add Error to FlutterError Conversion` darwin/Classes/UniversalBleHelper.swift Added `toFlutterError` extension to `Error` for converting to `FlutterError`.	+9/-0
UniversalBlePlugin.swift `Improve Error Handling in BLE Operations` darwin/Classes/UniversalBlePlugin.swift Updated `didWriteValueForCharacteristic` and `didUpdateValueForCharacteristic` to use `toFlutterError` for error handling.	+7/-7

✨ Usage guide:

**Overview:** The `describe` tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered [automatically](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) every time a new PR is opened, or can be invoked manually by commenting on a PR. When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L46) related to the describe tool (`pr_description` section), use the following template: ``` /describe --pr_description.some_config1=... --pr_description.some_config2=... ``` With a [configuration file](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-app), use the following template: ``` [pr_description] some_config1=... some_config2=... ```

Enabling\disabling automation

- When you first install the app, the [default mode](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) for the describe tool is: ``` pr_commands = ["/describe --pr_description.add_original_user_description=true" "--pr_description.keep_original_user_title=true", ...] ``` meaning the `describe` tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description. - Markers are an alternative way to control the generated description, to give maximal control to the user. If you set: ``` pr_commands = ["/describe --pr_description.use_description_markers=true", ...] ``` the tool will replace every marker of the form `pr_agent:marker_name` in the PR description with the relevant content, where `marker_name` is one of the following: - `type`: the PR type. - `summary`: the PR summary. - `walkthrough`: the PR walkthrough. Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.

Custom labels

The default labels of the `describe` tool are quite generic: [`Bug fix`, `Tests`, `Enhancement`, `Documentation`, `Other`]. If you specify [custom labels](https://github.com/Codium-ai/pr-agent/blob/main/docs/DESCRIBE.md#handle-custom-labels-from-the-repos-labels-page-gem) in the repo's labels page or via configuration file, you can get tailored labels for your use cases. Examples for custom labels: - `Main topic:performance` - pr_agent:The main topic of this PR is performance - `New endpoint` - pr_agent:A new endpoint was added in this PR - `SQL query` - pr_agent:A new SQL query was added in this PR - `Dockerfile changes` - pr_agent:The PR contains changes in the Dockerfile - ... The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases. Note that Labels are not mutually exclusive, so you can add multiple label categories. Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.

Inline File Walkthrough 💎

For enhanced user experience, the `describe` tool can add file summaries directly to the "Files changed" tab in the PR page. This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs). To enable inline file summary, set `pr_description.inline_file_summary` in the configuration file, possible values are: - `'table'`: File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab. - `true`: A collapsable file comment with changes title and a changes summary for each file in the PR. - `false` (default): File changes walkthrough will be added only to the "Conversation" tab.

Utilizing extra instructions

The `describe` tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description. Examples for extra instructions: ``` [pr_description] extra_instructions=""" - The PR title should be in the format: ': ' - The title should be short and concise (up to 10 words) - ... """ ``` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable. </details></td></tr> <tr><td><details> <summary><strong> More PR-Agent commands</strong></summary><hr> > To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \<QUESTION\>**: Ask a question about the PR. > - **/update_changelog**: Update the changelog based on the PR's contents. > - **/add_docs** 💎: Generate docstring for new components introduced in the PR. > - **/generate_labels** 💎: Generate labels for the PR based on the PR's contents. > - **/analyze** 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. >See the [tools guide](https://github.com/Codium-ai/pr-agent/blob/main/docs/TOOLS_GUIDE.md) for more details. >To list the possible configuration parameters, add a **/config** comment. </details></td></tr> </table> See the [describe usage](https://github.com/Codium-ai/pr-agent/blob/main/docs/DESCRIBE.md) page for a comprehensive guide on using this tool. </details> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/codiumai-pr-agent[bot]"><img src="https://avatars.githubusercontent.com/in/354216?v=4" />codiumai-pr-agent[bot]</a> commented <strong> 3 months ago</strong> </div> <div class="markdown-body"> <p><strong><a href="https://github.com/Navideck/universal_ble/pull/10">PR Description</a></strong> updated to latest commit (<a href="https://github.com/Navideck/universal_ble/commit/84c3071c60b61361cefa8a2f49b1969e44c4fb3e">https://github.com/Navideck/universal_ble/commit/84c3071c60b61361cefa8a2f49b1969e44c4fb3e</a>)</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/codiumai-pr-agent[bot]"><img src="https://avatars.githubusercontent.com/in/354216?v=4" />codiumai-pr-agent[bot]</a> commented <strong> 3 months ago</strong> </div> <div class="markdown-body"> <h2>PR Review</h2> <table> <tr> <td> <strong>PR feedback</strong> </td> <td></td></tr><tr><td> ⏱️ Estimated effort to review [1-5]</td><td> 2, because the changes are focused on specific enhancements and bug fixes related to error handling in both Android and iOS platforms. The modifications are well-contained within existing functions and the addition of new utility functions, making it easier to understand the context and impact of the changes. </td></tr> <tr><td> 🧪 Relevant tests</td><td> No </td></tr> <tr><td> 🔍 Possible issues</td><td> - The use of hardcoded error codes (e.g., `0x01`, `0x04`, etc.) in `parseGattErrorCode` might make the code harder to maintain or understand without referring to external documentation. Consider defining these as named constants for better readability and maintainability. - The error handling in both Android and iOS platforms now converts errors to a more generic `FlutterError` without much detail about the original error source (especially in iOS). Ensure that this level of abstraction is sufficient for debugging and user feedback. </td></tr> <tr><td> 🔒 Security concerns</td><td> No </td></tr> </table> <hr> <details> <summary><strong>✨ Usage guide:</strong></summary><hr> **Overview:** The `review` tool scans the PR code changes, and generates a PR review. The tool can be triggered [automatically](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) every time a new PR is opened, or can be invoked manually by commenting on any PR. When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L19) related to the review tool (`pr_reviewer` section), use the following template: ``` /review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=... ``` With a [configuration file](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-app), use the following template: ``` [pr_reviewer] some_config1=... some_config2=... ``` <table><tr><td><details> <summary><strong> Utilizing extra instructions</strong></summary><hr> The `review` tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize. Examples for extra instructions: ``` [pr_reviewer] # /review # extra_instructions=""" In the 'possible issues' section, emphasize the following: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ ``` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable. </details></td></tr> <tr><td><details> <summary><strong> How to enable\disable automation</strong></summary><hr> - When you first install PR-Agent app, the [default mode](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) for the `review` tool is: ``` pr_commands = ["/review", ...] ``` meaning the `review` tool will run automatically on every PR, with the default configuration. Edit this field to enable/disable the tool, or to change the used configurations </details></td></tr> <tr><td><details> <summary><strong> Auto-labels</strong></summary><hr> The `review` tool can auto-generate two specific types of labels for a PR: - a `possible security issue` label, that detects possible [security issues](https://github.com/Codium-ai/pr-agent/blob/tr/user_description/pr_agent/settings/pr_reviewer_prompts.toml#L136) (`enable_review_labels_security` flag) - a `Review effort [1-5]: x` label, where x is the estimated effort to review the PR (`enable_review_labels_effort` flag) </details></td></tr> <tr><td><details> <summary><strong> Extra sub-tools</strong></summary><hr> The `review` tool provides a collection of possible feedbacks about a PR. It is recommended to review the [possible options](https://github.com/Codium-ai/pr-agent/blob/main/docs/REVIEW.md#enabledisable-features), and choose the ones relevant for your use case. Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example: `require_score_review`, `require_soc2_ticket`, and more. </details></td></tr> <tr><td><details> <summary><strong> Auto-approve PRs</strong></summary><hr> By invoking: ``` /review auto_approve ``` The tool will automatically approve the PR, and add a comment with the approval. To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following: ``` [pr_reviewer] enable_auto_approval = true ``` (this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository) You can also enable auto-approval only if the PR meets certain requirements, such as that the `estimated_review_effort` is equal or below a certain threshold, by adjusting the flag: ``` [pr_reviewer] maximal_review_effort = 5 ``` </details></td></tr> <tr><td><details> <summary><strong> More PR-Agent commands</strong></summary><hr> > To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \<QUESTION\>**: Ask a question about the PR. > - **/update_changelog**: Update the changelog based on the PR's contents. > - **/add_docs** 💎: Generate docstring for new components introduced in the PR. > - **/generate_labels** 💎: Generate labels for the PR based on the PR's contents. > - **/analyze** 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. >See the [tools guide](https://github.com/Codium-ai/pr-agent/blob/main/docs/TOOLS_GUIDE.md) for more details. >To list the possible configuration parameters, add a **/config** comment. </details></td></tr> </table> See the [review usage](https://github.com/Codium-ai/pr-agent/blob/main/docs/REVIEW.md) page for a comprehensive guide on using this tool. </details> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/codiumai-pr-agent[bot]"><img src="https://avatars.githubusercontent.com/in/354216?v=4" />codiumai-pr-agent[bot]</a> commented <strong> 3 months ago</strong> </div> <div class="markdown-body"> <h2>PR Code Suggestions</h2> <table><thead><tr><th></th><th>Suggestions </th></tr></thead><tbody><tr><td><strong>enhancement</strong></td><td><table><tr><td> <details><summary>Add specific cases for known but unhandled BluetoothGatt status codes. </summary> ___ **Consider adding a default case for known but unhandled BluetoothGatt status codes to <br>provide more informative error messages for future debugging and maintenance. This can be <br>done by adding a specific case for known status codes that are not currently handled <br>explicitly in your <code>when</code> statement.** [android/src/main/kotlin/com/navideck/universal_ble/UniversalBleHelper.kt [131]](https://github.com/Navideck/universal_ble/pull/10/files#diff-07528325c9af8065d3fe07cc2436350a5db4dde75378b96e4801cdc7675b128aR131-R131) ```diff +0x07 -> "GATT_WRITE_REQ_REJECTED" else -> "Unknown Error: $this" ``` </details></td></tr><tr><td> <details><summary>Include NSError userInfo in FlutterError details for better error context. </summary> ___ **To provide more context in the error details when converting an <code>Error</code> to a <code>FlutterError</code>, <br>consider including the <code>userInfo</code> dictionary from <code>NSError</code> in the <code>details</code> parameter. This can <br>give more insights into the error, especially when debugging.** [darwin/Classes/UniversalBleHelper.swift [109]](https://github.com/Navideck/universal_ble/pull/10/files#diff-64579e5454d2beef64b5056e1f9eea6e9f92006164a448fcd4207c126df2af48R109-R109) ```diff -return FlutterError(code: errorCode, message: errorDescription, details: nil) +return FlutterError(code: errorCode, message: errorDescription, details: nsError.userInfo) ``` </details></td></tr></table></td></tr><tr><td><strong>maintainability</strong></td><td><table><tr><td> <details><summary>Refactor error handling to reduce code duplication. </summary> ___ **Refactor the error handling in <code>onCharacteristicRead</code> and <code>onCharacteristicWrite</code> to a <br>separate method to reduce code duplication and improve maintainability. This method would <br>take the <code>status</code> and <code>it</code> (the future) as parameters and handle the success and failure cases <br>accordingly.** [android/src/main/kotlin/com/navideck/universal_ble/UniversalBlePlugin.kt [270-281]](https://github.com/Navideck/universal_ble/pull/10/files#diff-9bf8297311d93083e68b98b07fd87ec8038bf693833cef20b676ac88a4aa837eR270-R281) ```diff -if (status == BluetoothGatt.GATT_SUCCESS) { - it.result(Result.success(value)) -} else { - it.result( - Result.failure( - FlutterError( - status.toString(), - "Failed to read: (${status.parseGattErrorCode()})", - null, - ) - ) - ) -} +handleCharacteristicOperationResult(status, it, value) ``` </details></td></tr></table></td></tr><tr><td><strong>best practice</strong></td><td><table><tr><td> <details><summary>Define a constant for the "NotSupported" error code. </summary> ___ **For consistency and to avoid magic strings, define a constant for the error code <br>"NotSupported" used in <code>enableBluetooth</code> method. This improves code readability and <br>maintainability, making it easier to manage error codes.** [darwin/Classes/UniversalBlePlugin.swift [56]](https://github.com/Navideck/universal_ble/pull/10/files#diff-87832239a271a17152d0bd5fd33a705cd1398bda21bfdfff19934f405c09965fR56-R56) ```diff -completion(Result.failure(FlutterError(code: "NotSupported", message: nil, details: nil))) +let notSupportedErrorCode = "NotSupported" +completion(Result.failure(FlutterError(code: notSupportedErrorCode, message: nil, details: nil))) ``` </details></td></tr><tr><td> <details><summary>Use pattern matching for error handling to improve clarity. </summary> ___ **Instead of directly checking for <code>error != nil</code> to decide whether to fail or succeed the <br>future in <code>didWriteValueFor</code> and <code>didUpdateValueFor</code>, use pattern matching to make the intent <br>clearer and the code more concise.** [darwin/Classes/UniversalBlePlugin.swift [283-287]](https://github.com/Navideck/universal_ble/pull/10/files#diff-87832239a271a17152d0bd5fd33a705cd1398bda21bfdfff19934f405c09965fR283-R287) ```diff -if let flutterError = error?.toFlutterError() { - future.result(Result.failure(flutterError)) -} else { +switch error { +case .some(let error): + future.result(Result.failure(error.toFlutterError())) +case .none: future.result(Result.success({}())) } ``` </details></td></tr></table></td></tr></tr></tbody></table><hr> <details> <summary><strong>✨ Usage guide:</strong></summary><hr> **Overview:** The `improve` tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered [automatically](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) every time a new PR is opened, or can be invoked manually by commenting on a PR. When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L69) related to the improve tool (`pr_code_suggestions` section), use the following template: ``` /improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=... ``` With a [configuration file](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-app), use the following template: ``` [pr_code_suggestions] some_config1=... some_config2=... ``` <table><tr><td><details> <summary><strong> Enabling\disabling automation </strong></summary><hr> When you first install the app, the [default mode](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) for the improve tool is: ``` pr_commands = ["/improve --pr_code_suggestions.summarize=true", ...] ``` meaning the `improve` tool will run automatically on every PR, with summarization enabled. Delete this line to disable the tool from running automatically. </details></td></tr> <tr><td><details> <summary><strong> Utilizing extra instructions</strong></summary><hr> Extra instructions are very important for the `improve` tool, since they enable to guide the model to suggestions that are more relevant to the specific needs of the project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify relevant aspects that you want the model to focus on. Examples for extra instructions: ``` [pr_code_suggestions] # /improve # extra_instructions=""" Emphasize the following aspects: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ ``` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable. </details></td></tr> <tr><td><details> <summary><strong> A note on code suggestions quality</strong></summary><hr> - While the current AI for code is getting better and better (GPT-4), it's not flawless. Not all the suggestions will be perfect, and a user should not accept all of them automatically. - Suggestions are not meant to be simplistic. Instead, they aim to give deep feedback and raise questions, ideas and thoughts to the user, who can then use his judgment, experience, and understanding of the code base. - Recommended to use the 'extra_instructions' field to guide the model to suggestions that are more relevant to the specific needs of the project, or use the [custom suggestions :gem:](https://github.com/Codium-ai/pr-agent/blob/main/docs/CUSTOM_SUGGESTIONS.md) tool - With large PRs, best quality will be obtained by using 'improve --extended' mode. </details></td></tr> <tr><td><details> <summary><strong> More PR-Agent commands</strong></summary><hr> > To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \<QUESTION\>**: Ask a question about the PR. > - **/update_changelog**: Update the changelog based on the PR's contents. > - **/add_docs** 💎: Generate docstring for new components introduced in the PR. > - **/generate_labels** 💎: Generate labels for the PR based on the PR's contents. > - **/analyze** 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. >See the [tools guide](https://github.com/Codium-ai/pr-agent/blob/main/docs/TOOLS_GUIDE.md) for more details. >To list the possible configuration parameters, add a **/config** comment. </details></td></tr> </table> See the [improve usage](https://github.com/Codium-ai/pr-agent/blob/main/docs/IMPROVE.md) page for a more comprehensive guide on using this tool. </details> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

Navideck / universal_ble