Navideck / universal_ble

A cross-platform Android/iOS/macOS/Windows/Linux/Web Bluetooth Low Energy (BLE) plugin for Flutter
https://pub.dev/packages/universal_ble
Other
19 stars 2 forks source link

Windows scan fix #5

Closed rohitsangwan01 closed 3 months ago

rohitsangwan01 commented 3 months ago

Type

Enhancement, Bug fix


Description


Changes walkthrough

Relevant files
Code cleanup
utils.cpp
Clean up and remove unnecessary comments in utils.cpp                       

windows/src/helper/utils.cpp - Removed unnecessary comments. - Removed a TODO comment about input validation in `_str_to_mac_address`
function. - Removed a TODO comment about cleanup/validation in `uuid_to_guid`
function. - Removed a TODO comment about using snprintf instead of string streams
in `guid_to_uuid` function.
+1/-9     
utils.h
Remove unused structs and function in utils.h                                       

windows/src/helper/utils.h - Removed the `ConnectionStateStruct`, `PairStateStruct`, and `
``ValueChangeStruct`
structs. - Removed the `async_get` function.
+2/-28   
Code refactoring
universal_ble_plugin.cpp
Refactor and improve code readability in universal_ble_plugin.cpp

windows/src/universal_ble_plugin.cpp - Removed the `pushUniversalScanResult` function. - Refactored the `setupDeviceWatcher` function to improve code
readability. - Refactored the `onDeviceInfoRecieved` function to improve code
readability. - Refactored the `BluetoothLEWatcher_Received` function to improve code
readability.
+70/-100
universal_ble_base.h
Move enum definitions to universal_ble_base.h                                       

windows/src/helper/universal_ble_base.h - Moved all enum definitions from `universal_enum.h` to
`universal_ble_base.h`.
+43/-0   
universal_enum.h
Remove universal_enum.h                                                                                   

windows/src/helper/universal_enum.h - Removed the file as all its content was moved to
`universal_ble_base.h`.
+0/-47   
universal_ble_plugin.h
Update universal_ble_plugin.h                                                                       

windows/src/universal_ble_plugin.h - Removed the `pushUniversalScanResult` function declaration. - Removed the inclusion of `universal_enum.h`.
+0/-2     
Build configuration
CMakeLists.txt
Update CMakeLists.txt                                                                                       

windows/CMakeLists.txt - Removed `universal_enum.h` from the list of source files.
+0/-1     

โœจ Usage guide:
**Overview:** The `describe` tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered [automatically](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) every time a new PR is opened, or can be invoked manually by commenting on a PR. When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L46) related to the describe tool (`pr_description` section), use the following template: ``` /describe --pr_description.some_config1=... --pr_description.some_config2=... ``` With a [configuration file](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-app), use the following template: ``` [pr_description] some_config1=... some_config2=... ```
Enabling\disabling automation
- When you first install the app, the [default mode](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) for the describe tool is: ``` pr_commands = ["/describe --pr_description.add_original_user_description=true" "--pr_description.keep_original_user_title=true", ...] ``` meaning the `describe` tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description. - Markers are an alternative way to control the generated description, to give maximal control to the user. If you set: ``` pr_commands = ["/describe --pr_description.use_description_markers=true", ...] ``` the tool will replace every marker of the form `pr_agent:marker_name` in the PR description with the relevant content, where `marker_name` is one of the following: - `type`: the PR type. - `summary`: the PR summary. - `walkthrough`: the PR walkthrough. Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.
Custom labels
The default labels of the `describe` tool are quite generic: [`Bug fix`, `Tests`, `Enhancement`, `Documentation`, `Other`]. If you specify [custom labels](https://github.com/Codium-ai/pr-agent/blob/main/docs/DESCRIBE.md#handle-custom-labels-from-the-repos-labels-page-gem) in the repo's labels page or via configuration file, you can get tailored labels for your use cases. Examples for custom labels: - `Main topic:performance` - pr_agent:The main topic of this PR is performance - `New endpoint` - pr_agent:A new endpoint was added in this PR - `SQL query` - pr_agent:A new SQL query was added in this PR - `Dockerfile changes` - pr_agent:The PR contains changes in the Dockerfile - ... The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases. Note that Labels are not mutually exclusive, so you can add multiple label categories. Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.
Inline File Walkthrough ๐Ÿ’Ž
For enhanced user experience, the `describe` tool can add file summaries directly to the "Files changed" tab in the PR page. This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs). To enable inline file summary, set `pr_description.inline_file_summary` in the configuration file, possible values are: - `'table'`: File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab. - `true`: A collapsable file comment with changes title and a changes summary for each file in the PR. - `false` (default): File changes walkthrough will be added only to the "Conversation" tab.
Utilizing extra instructions
The `describe` tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description. Examples for extra instructions: ``` [pr_description] extra_instructions=""" - The PR title should be in the format: ': ' - The title should be short and concise (up to 10 words) - ... """ ``` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable. </details></td></tr> <tr><td><details> <summary><strong> More PR-Agent commands</strong></summary><hr> > To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \<QUESTION\>**: Ask a question about the PR. > - **/update_changelog**: Update the changelog based on the PR's contents. > - **/add_docs** ๐Ÿ’Ž: Generate docstring for new components introduced in the PR. > - **/generate_labels** ๐Ÿ’Ž: Generate labels for the PR based on the PR's contents. > - **/analyze** ๐Ÿ’Ž: Automatically analyzes the PR, and presents changes walkthrough for each component. >See the [tools guide](https://github.com/Codium-ai/pr-agent/blob/main/docs/TOOLS_GUIDE.md) for more details. >To list the possible configuration parameters, add a **/config** comment. </details></td></tr> </table> See the [describe usage](https://github.com/Codium-ai/pr-agent/blob/main/docs/DESCRIBE.md) page for a comprehensive guide on using this tool. </details> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/codiumai-pr-agent[bot]"><img src="https://avatars.githubusercontent.com/in/354216?v=4" />codiumai-pr-agent[bot]</a> commented <strong> 3 months ago</strong> </div> <div class="markdown-body"> <p><strong><a href="https://github.com/Navideck/universal_ble/pull/5">PR Description</a></strong> updated to latest commit (<a href="https://github.com/Navideck/universal_ble/commit/9d818604f5e90694751d5eceb8c28a24903bcb32">https://github.com/Navideck/universal_ble/commit/9d818604f5e90694751d5eceb8c28a24903bcb32</a>)</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/codiumai-pr-agent[bot]"><img src="https://avatars.githubusercontent.com/in/354216?v=4" />codiumai-pr-agent[bot]</a> commented <strong> 3 months ago</strong> </div> <div class="markdown-body"> <h2>PR Analysis</h2> <ul> <li>๐ŸŽฏ <strong>Main theme:</strong> Code cleanup and refactoring in a Bluetooth Low Energy (BLE) plugin for Windows.</li> <li>๐Ÿ“ <strong>PR summary:</strong> This PR focuses on cleaning up the code and improving its structure in a BLE plugin for Windows. It removes unnecessary comments, refactors some parts of the code for better readability and maintainability, and moves all enum definitions from one header file to another, removing the original file. It also updates the relevant files to reflect these changes.</li> <li>๐Ÿ“Œ <strong>Type of PR:</strong> Enhancement</li> <li>๐Ÿงช <strong>Relevant tests added:</strong> No</li> <li>โฑ๏ธ <strong>Estimated effort to review [1-5]:</strong> 3, because the PR involves several changes in different parts of the code, including refactoring and code removals. Understanding the context and impact of these changes requires familiarity with the codebase.</li> <li>๐Ÿ”’ <strong>Security concerns:</strong> No security concerns found <h2>PR Feedback</h2></li> </ul> <p><strong>๐Ÿ’ก General suggestions:</strong> The PR generally looks good. The code is cleaner and more readable after the changes. However, it would be beneficial to add some comments explaining the logic behind the refactoring and the removals, especially for other developers who might work on this code in the future. Also, it would be good to add some unit tests to ensure that the changes haven't broken any existing functionality.</p> <hr> <details> <summary><strong>โœจ Usage guide:</strong></summary><hr> **Overview:** The `review` tool scans the PR code changes, and generates a PR review. The tool can be triggered [automatically](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) every time a new PR is opened, or can be invoked manually by commenting on any PR. When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L19) related to the review tool (`pr_reviewer` section), use the following template: ``` /review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=... ``` With a [configuration file](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-app), use the following template: ``` [pr_reviewer] some_config1=... some_config2=... ``` <table><tr><td><details> <summary><strong> Utilizing extra instructions</strong></summary><hr> The `review` tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize. Examples for extra instructions: ``` [pr_reviewer] # /review # extra_instructions=""" In the 'general suggestions' section, emphasize the following: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ ``` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable. </details></td></tr> <tr><td><details> <summary><strong> How to enable\disable automation</strong></summary><hr> - When you first install PR-Agent app, the [default mode](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) for the `review` tool is: ``` pr_commands = ["/review", ...] ``` meaning the `review` tool will run automatically on every PR, with the default configuration. Edit this field to enable/disable the tool, or to change the used configurations </details></td></tr> <tr><td><details> <summary><strong> Auto-labels</strong></summary><hr> The `review` tool can auto-generate two specific types of labels for a PR: - a `possible security issue` label, that detects possible [security issues](https://github.com/Codium-ai/pr-agent/blob/tr/user_description/pr_agent/settings/pr_reviewer_prompts.toml#L136) (`enable_review_labels_security` flag) - a `Review effort [1-5]: x` label, where x is the estimated effort to review the PR (`enable_review_labels_effort` flag) </details></td></tr> <tr><td><details> <summary><strong> Extra sub-tools</strong></summary><hr> The `review` tool provides a collection of possible feedbacks about a PR. It is recommended to review the [possible options](https://github.com/Codium-ai/pr-agent/blob/main/docs/REVIEW.md#enabledisable-features), and choose the ones relevant for your use case. Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example: `require_score_review`, `require_soc2_ticket`, and more. </details></td></tr> <tr><td><details> <summary><strong> More PR-Agent commands</strong></summary><hr> > To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \<QUESTION\>**: Ask a question about the PR. > - **/update_changelog**: Update the changelog based on the PR's contents. > - **/add_docs** ๐Ÿ’Ž: Generate docstring for new components introduced in the PR. > - **/generate_labels** ๐Ÿ’Ž: Generate labels for the PR based on the PR's contents. > - **/analyze** ๐Ÿ’Ž: Automatically analyzes the PR, and presents changes walkthrough for each component. >See the [tools guide](https://github.com/Codium-ai/pr-agent/blob/main/docs/TOOLS_GUIDE.md) for more details. >To list the possible configuration parameters, add a **/config** comment. </details></td></tr> </table> See the [review usage](https://github.com/Codium-ai/pr-agent/blob/main/docs/REVIEW.md) page for a comprehensive guide on using this tool. </details> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/codiumai-pr-agent[bot]"><img src="https://avatars.githubusercontent.com/in/354216?v=4" />codiumai-pr-agent[bot]</a> commented <strong> 3 months ago</strong> </div> <div class="markdown-body"> <h2>PR Code Suggestions</h2> <table><thead><tr><th></th><th>Suggestions                                                                                                                                                          </th></tr></thead><tbody><tr><td><strong>possible issue</strong></td><td><table><tr><td> <details><summary>Add input validation to the <code>_str_to_mac_address</code> function.       </summary> ___ **In the function `_str_to_mac_address`, there is no validation of the input string `<br> ``mac_str`. `<br> `This `<br> `could `<br> `lead `<br> `to `<br> `unexpected `<br> `behavior `<br> `or `<br> `crashes `<br> `if `<br> `the `<br> `input `<br> `string `<br> `is `<br> `not `<br> `in `<br> `the `<br> `expected `<br> `format. `<br> `Consider `<br> `adding `<br> `a `<br> `check `<br> `to `<br> `ensure `<br> `that `<br> `the `<br> `input `<br> `string `<br> `is `<br> `in `<br> `the `<br> `correct `<br> `format `<br> `before `<br> `attempting `<br> `to `<br> `parse `<br> `it.** [windows/src/helper/utils.cpp [29-33]](https://github.com/Navideck/universal_ble/pull/5/files#diff-f57bbf2c04edf671bf050215c1d4e9f10a8a42db38a63c1f1932eae62fcf9b1cR29-R33) ```diff uint64_t _str_to_mac_address(std::string mac_str) { + if (!std::regex_match(mac_str, std::regex("^([0-9A-Fa-f]{2}[:-]){5}([0-9A-Fa-f]{2})$"))) + { + throw std::invalid_argument("Invalid MAC address format"); + } uint64_t mac_address_number = 0; uint8_t *mac_ptr = (uint8_t *)&mac_address_number; sscanf_s(mac_str.c_str(), "%02hhx:%02hhx:%02hhx:%02hhx:%02hhx:%02hhx", &mac_ptr[5], &mac_ptr[4], &mac_ptr[3], } ``` </details></td></tr><tr><td> <details><summary>Add input validation to the <code>uuid_to_guid</code> function.              </summary> ___ **In the `uuid_to_guid` function, there is no validation of the input string `uuid`. This `<br> `could `<br> `lead `<br> `to `<br> `unexpected `<br> `behavior `<br> `or `<br> `crashes `<br> `if `<br> `the `<br> `input `<br> `string `<br> `is `<br> `not `<br> `in `<br> `the `<br> `expected `<br> `format. `<br> `Consider `<br> `adding `<br> `a `<br> `check `<br> `to `<br> `ensure `<br> `that `<br> `the `<br> `input `<br> `string `<br> `is `<br> `in `<br> `the `<br> `correct `<br> `format `<br> `before `<br> `attempting `<br> `to `<br> `parse `<br> `it.** [windows/src/helper/utils.cpp [38-42]](https://github.com/Navideck/universal_ble/pull/5/files#diff-f57bbf2c04edf671bf050215c1d4e9f10a8a42db38a63c1f1932eae62fcf9b1cR38-R42) ```diff winrt::guid uuid_to_guid(const std::string &uuid) { + if (!std::regex_match(uuid, std::regex("^[0-9A-Fa-f]{8}-[0-9A-Fa-f]{4}-[0-9A-Fa-f]{4}-[0-9A-Fa-f]{4}-[0-9A-Fa-f]{12}$"))) + { + throw std::invalid_argument("Invalid UUID format"); + } std::stringstream helper; for (int i = 0; i < uuid.length(); i++) { // ... more code ... } } ``` </details></td></tr></table></td></tr><tr><td><strong>enhancement</strong></td><td><table><tr><td> <details><summary>Refactor repeated code in <code>onDeviceInfoRecieved</code> function into a helper function.</summary> ___ **In the `onDeviceInfoRecieved` function, there is a lot of repeated code for checking if a <br> value is empty and then setting it. This could be simplified by creating a helper function <br> that takes the old and new values, and returns the new value if it's not empty, or the old <br> value otherwise.** [windows/src/universal_ble_plugin.cpp [572-599]](https://github.com/Navideck/universal_ble/pull/5/files#diff-c744a38517e9dcb9177126ffd1392b9decc2b53e55772d4270f4387a4f4c9357R572-R599) ```diff -if (!name.empty() && (_scanResult.name() == nullptr || _scanResult.name()->empty() || *_scanResult.name() != name)) -{ - _scanResult.set_name(name); - shouldUpdate = true; +_scanResult.set_name(getUpdatedValue(_scanResult.name(), name, shouldUpdate)); +_scanResult.set_is_paired(getUpdatedValue(_scanResult.is_paired(), isPaired, shouldUpdate)); + +// Helper function +template <typename T> +T getUpdatedValue(T oldValue, T newValue, bool& shouldUpdate) { + if (!newValue.empty() && (oldValue == nullptr || oldValue->empty() || *oldValue != newValue)) { + shouldUpdate = true; + return newValue; + } + return oldValue; } -if (_scanResult.is_paired() == nullptr || *_scanResult.is_paired() != isPaired) -{ - _scanResult.set_is_paired(isPaired); - shouldUpdate = true; -} - ``` </details></td></tr></table></td></tr><tr><td><strong>maintainability</strong></td><td><table><tr><td> <details><summary>Reduce the amount of code inside try-catch blocks in the <code>BluetoothLEWatcher_Received</code> function.</summary> ___ **In the `BluetoothLEWatcher_Received` function, there is a large amount of code inside a <br> try-catch block. This could make it difficult to understand which specific lines of code <br> might throw an exception. Consider reducing the amount of code inside the try-catch block, <br> or using multiple try-catch blocks with specific exception types to make it clearer what <br> exceptions might be thrown.** [windows/src/universal_ble_plugin.cpp [658-674]](https://github.com/Navideck/universal_ble/pull/5/files#diff-c744a38517e9dcb9177126ffd1392b9decc2b53e55772d4270f4387a4f4c9357R658-R674) ```diff +auto deviceId = _mac_address_to_str(args.BluetoothAddress()); +auto universalScanResult = UniversalBleScanResult(deviceId); +std::string name; try { - auto deviceId = _mac_address_to_str(args.BluetoothAddress()); - auto universalScanResult = UniversalBleScanResult(deviceId); - std::string name = winrt::to_string(args.Advertisement().LocalName()); - auto manufacturerData = parseManufacturerDataHead(args.Advertisement(), deviceId); - // ... more code ... + name = winrt::to_string(args.Advertisement().LocalName()); +} +catch (...) +{ + // handle exception +} +// ... more code ... +try +{ uiThreadHandler_.Post([universalScanResult] { callbackChannel->OnScanResult(universalScanResult, SuccessCallback, ErrorCallback); }); } catch (...) { // handle exception } ``` </details></td></tr></table></td></tr></tr></tbody></table><hr> <details> <summary><strong>โœจ Usage guide:</strong></summary><hr> **Overview:** The `improve` tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered [automatically](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) every time a new PR is opened, or can be invoked manually by commenting on a PR. When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L69) related to the improve tool (`pr_code_suggestions` section), use the following template: ``` /improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=... ``` With a [configuration file](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-app), use the following template: ``` [pr_code_suggestions] some_config1=... some_config2=... ``` <table><tr><td><details> <summary><strong> Enabling\disabling automation </strong></summary><hr> When you first install the app, the [default mode](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) for the improve tool is: ``` pr_commands = ["/improve --pr_code_suggestions.summarize=true", ...] ``` meaning the `improve` tool will run automatically on every PR, with summarization enabled. Delete this line to disable the tool from running automatically. </details></td></tr> <tr><td><details> <summary><strong> Utilizing extra instructions</strong></summary><hr> Extra instructions are very important for the `improve` tool, since they enable to guide the model to suggestions that are more relevant to the specific needs of the project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify relevant aspects that you want the model to focus on. Examples for extra instructions: ``` [pr_code_suggestions] # /improve # extra_instructions=""" Emphasize the following aspects: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ ``` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable. </details></td></tr> <tr><td><details> <summary><strong> A note on code suggestions quality</strong></summary><hr> - While the current AI for code is getting better and better (GPT-4), it's not flawless. Not all the suggestions will be perfect, and a user should not accept all of them automatically. - Suggestions are not meant to be simplistic. Instead, they aim to give deep feedback and raise questions, ideas and thoughts to the user, who can then use his judgment, experience, and understanding of the code base. - Recommended to use the 'extra_instructions' field to guide the model to suggestions that are more relevant to the specific needs of the project, or use the [custom suggestions :gem:](https://github.com/Codium-ai/pr-agent/blob/main/docs/CUSTOM_SUGGESTIONS.md) tool - With large PRs, best quality will be obtained by using 'improve --extended' mode. </details></td></tr> <tr><td><details> <summary><strong> More PR-Agent commands</strong></summary><hr> > To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \<QUESTION\>**: Ask a question about the PR. > - **/update_changelog**: Update the changelog based on the PR's contents. > - **/add_docs** ๐Ÿ’Ž: Generate docstring for new components introduced in the PR. > - **/generate_labels** ๐Ÿ’Ž: Generate labels for the PR based on the PR's contents. > - **/analyze** ๐Ÿ’Ž: Automatically analyzes the PR, and presents changes walkthrough for each component. >See the [tools guide](https://github.com/Codium-ai/pr-agent/blob/main/docs/TOOLS_GUIDE.md) for more details. >To list the possible configuration parameters, add a **/config** comment. </details></td></tr> </table> See the [improve usage](https://github.com/Codium-ai/pr-agent/blob/main/docs/IMPROVE.md) page for a more comprehensive guide on using this tool. </details> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>ยฉ <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>