Naxela / The_Lightmapper

Fast and easy baked GI Lightmaps for Blender and Cycles
GNU General Public License v3.0
719 stars 53 forks source link

Multiple objects, one at a time #148

Open ArtsyVR opened 2 years ago

ArtsyVR commented 2 years ago

Amazing addon, I’ve been using it for months and I literally cannot use any other addon :) It’s so good.

I am wanting to bake one object at a time. So I disable the previously baked object and then I bake another object. When I do that, the first baked object turns black. Is there a way to only bake one object at a time and it not affect the other baked objects?

In my system preferences I have Nvidia 3070 and Amd Ryzen 9 5900H enabled under CUDA. However when I use Optix Denoising the object runs back pink. How should I have my settings setup to use the denoising?

Naxela commented 2 years ago

Hi, thanks for using it! :)

As for the first problem/bug, have I understood it correctly that you disable it by removing the toggle for lightmapping in the object settings? In that case, it sounds strange, as it shouldn't happen. I will try to figure out why it happens.

As for Optix denoising, I must admit I haven't tried it in a while since I mainly use Linux. Generally I'd recommend using Intel OIDN and just point to the oidnDenoise.exe. For Optix it isn't updated that often, but I tested using the denoiser from here: https://github.com/DeclanRussell/NvidiaAIDenoiser - and just pointed to the denoiser binary - But I'll test it out some more in the coming weekend, just to test if things have changed lately

ArtsyVR commented 2 years ago

Thank you! And yes, when I toggle off it does make the object next to it black. I think it’s actually losing track of the previous Lightmap because the next bake (say two cubes side by side) has pink casted on it. The pink you see when a texture is missing.

ArtsyVR commented 2 years ago

Thank you for the Optix denoiser link, I didn’t have that downloaded before. Now all is well :)

Naxela commented 2 years ago

Hi, I've added a possible fix for the bug (https://github.com/Naxela/The_Lightmapper/commits/master), I can't remember entirely why I added the code causing the bug - Maybe it'll introduce other bugs, but at least it should work for now in this case :D

As for the optix denoiser, does that mean it works? In that case, it's good!

ArtsyVR commented 2 years ago

Omg brilliant! Thank you so much!!

ArtsyVR commented 2 years ago

And yes the Optix and the enable/disable button works perfect

Naxela commented 2 years ago

Hi, thanks for reporting back 👍

Good to hear it seems to be working now :)