search

Naxesss / MapsetVerifier

A modding tool for osu!
93 stars 8 forks source link

Some skin files are not recognized (e.g. mania combobursts) #11

Open Asphyre opened 3 years ago

Asphyre commented 3 years ago

Mapset Verifier doesnt seem to treat skin files as used ones since the file still shows up as unused in MV

Naxesss commented 3 years ago

Which skin file is this in specific, and is there a mapset with this issue I can look at? Most of them should be detected if they're actually used.

Asphyre commented 3 years ago

https://osu.ppy.sh/beatmapsets/1169658 comboburst files

https://osu.ppy.sh/community/forums/topics/1126031

dudehacker commented 3 years ago

while you are at it, fix it for mania too

problem map: https://osu.ppy.sh/beatmapsets/1245882#mania/2589780

error screenshot https://i.imgur.com/nQ64sjm.png

skin wiki https://osu.ppy.sh/help/wiki/Skinning/osu!mania#comboburst

Naxesss commented 3 years ago

have fixed both, also added support for other taiko/catch/mania skin elements

dudehacker commented 2 years ago

its still showing error for "comboburst-mania-0.png" on latest version of 1.8.2

map with issue: https://osu.ppy.sh/beatmapsets/1226426#mania/2550329 screenshot

dudehacker commented 2 years ago

different issue related to combo burst https://osu.ppy.sh/wiki/en/Skinning/osu%21mania

combo burst is Max height: 768px

but i tried using higher resolution image, its not flagged as problem