search

Naxesss / MapsetVerifier

A modding tool for osu!
94 stars 8 forks source link

Inconsistencies in snapping detection too sensitive? #2

Closed abraker95 closed 5 years ago

abraker95 commented 5 years ago

Got this on this beatmap, but there are more than two of such snapped hitobjects

Naxesss commented 5 years ago

can only see those two on 1/6, where are the other ones you mentioned?

abraker95 commented 5 years ago

ooo I see now. It doesn't see that the notes were shifted by 1/12 snapping. Most of those short hold notes start at 1/6 and end 1/12 except those two which start 1/12 and end 1/6.

Naxesss commented 5 years ago

ye you have a lot of lns ending on 1/12 but only those two are 1/6. Check doesn't really care about how long the sliders are, only which ticks they exist on. Reason why it's sensitive and easily does false positives is because it's commonly something people miss and maps need to be dqed for, not really sure if I could make this less sensitive while still being as safe (stuff like shifting by 1/16 is something it'd want to catch, for example)

abraker95 commented 5 years ago

Well ok, I guess there is no issue after all.