search

Naxesss / MapsetVerifier

A modding tool for osu!
93 stars 8 forks source link

Failing to detect certain sliders as offscreen #26

Open newzealandisthebest1 opened 1 year ago

newzealandisthebest1 commented 1 year ago

A couple of maps have got ranked recently with offscreen sliders that didn't get picked up by MV, which unfortunately is a violation of the Ranking Criteria. Here's this one for example (link: https://osu.ppy.sh/beatmapsets/1699993#osu/3497827): screenshot001

See? The left side of this slider is offscreen, but for whatever reason MV thought this slider wasn't.

Naxesss commented 1 year ago

The reason for this is that there's a tiny positional inaccuracy in the Bézier calculation. The more red anchors the slider has, the more this inaccuracy builds up, to the point where false negatives like these happen.

I've tried fixing this in the past, including copying what lazer does, but to no success. I'll probably try again at some point.