NaychiMin / pe

0 stars 0 forks source link

Delete recipe: Ingredient name after tag not recognised if there is spacing before #2

Open NaychiMin opened 11 months ago

NaychiMin commented 11 months ago

Deleting a recipe does not work if there is a space between the tag and the index/name after the tag.

image.png

soc-se-bot commented 11 months ago

Team's Response

Format is indeed incorrect and thus error message was returned. Same issue as master bug, solving master bug will solve this bug

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Empty spaces are not sufficinetly parsed

Screenshot 2023-11-17 at 5.07.14 PM.png

Unable to detect command correctly if 1 space before / is included. Parser could handle this better?


[original: nus-cs2113-AY2324S1/pe-interim#490] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Format is indeed incorrect and thus error message was returned. As there are different classes that uses add, we decided to implement several valid flags for recipes r/, ingredients i/, and shortcuts sc/. As sc / is an invalid flag, hence it will not detect the command.

We understand what tester means, but it is a very low priority feature, which most users will never face if they follow help commands or refer to UG/DG

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** > Format is indeed incorrect and thus error message was returned. The command 'delete r/ 1' is not considered invalid as the user is following the user guide by keying in delete r/RECIPE_ID and from the user's point of view, they do not see it as Id = " 1" and instead sees it as Id=1 which indeed is a valid and existing dish ID. Additionally, the UG did not specify this as 'not supported' or 'coming in the future version' as they should have if it was to be considered as 'response.NotInScope' as shown below. ![image.png](https://raw.githubusercontent.com/NaychiMin/pe/main/files/b504c427-1ae4-4c39-925f-cc38c7c88a8c.png) Hence, this should be considered as a valid bug.
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** This is a functionality bug as its behaviour differs from normal expectations. The expected output would have been to delete the respective dish. ![image.png](https://raw.githubusercontent.com/NaychiMin/pe/main/files/87629754-54c2-4a2a-8549-bd8da43ac8f5.png) The following bugs would be considered feature flaw: ![image.png](https://raw.githubusercontent.com/NaychiMin/pe/main/files/368ee2cf-5478-4cbb-884f-9742a09707f3.png)
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Only cosmetic bugs should be marked as very low as shown below. This is not a cosmetic bug. ![image.png](https://raw.githubusercontent.com/NaychiMin/pe/main/files/bc8c7db5-524b-4013-b623-0494137766bb.png) However, after thinking of it without the stress of PE, I realised that it should be of type 'severity.Low' and not 'severity.Medium' :)