search

Nazariglez / notan

Cross-platform multimedia layer
https://nazariglez.github.io/notan-web/
Apache License 2.0
802 stars 55 forks source link

Please remove the dependency on the crate glsl-to-spirv because it is unmaintained and abandoned #287

Closed yurivict closed 1 year ago

yurivict commented 1 year ago

See here.

Nazariglez commented 1 year ago

Hi @yurivict, alternatives are still not ideal. Only shaderc will take quite a few minutes to compile in the first compilation or after cargo clean. And Naga does not support quite good yet glsl as input.

Ideal scenario will be using naga with wgsl, but that will require a lot of changes across the API, and I am not capable to do that right now due time restrictions. But I am open to review and guide any PR if somebody is willing to put the work on it.

As alternative, you can disable glsl to spirv and enable shaderc compilation using feature flags in your cargo.toml

yurivict commented 1 year ago

I wasn't able to build https://github.com/woelper/oculante because it uses notan and glsl-to-spirv fails to build.

I guess I would just wait until this problem is resolved.

Nazariglez commented 1 year ago

I see, then it's an easy solution, we can add shaderc as a feature flag on oculante too. I am leaving there a comment.