Fix skybox index sentinel

NcStudios / NcEngine

NcEngine: 3D game engine written in modern C++ and Vulkan

https://ncstudios.itch.io/

MIT License

40 stars 2 forks source link

Fix skybox index sentinel #435

Closed McCallisterRomer closed 2 months ago

McCallisterRomer commented 7 months ago

In Pbr.frag we do a check for if (environmentData.skyboxCubemapIndex > -1), which is an unsigned value. This should be set and checked against correctly in Pbr.frag, EnvironmentDataShaderResource.cpp, and EnvironmentSystem.cpp.

jaremieromer commented 2 months ago

This was closed by #621