search

Nchatterji / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

Summary #4

Open thecodeduchess opened 6 years ago

thecodeduchess commented 6 years ago

Grade: Meets Expectations

Summary: This was a great implementation of the project. First, I test your project by downloading it and viewing it in my own browser. Next, I go step by step with your page against the requirements. It matches with the required specs. After nitpicking through it, I did not find anything that requires a re-do but you do have to adjust the linking to the CSS so that everyone else can see the styling.

The code was easily readable and met the required styling, class and ID naming. If you want to build onto this project or future projects, you could consider adding a border on some of the elements, changing the font design, background color or use other various font colors. Don't be afraid to experiment a little bit. :) That is allowed as long as you are following the general structure/page layout for practice.

I hope you are enjoying your learning experience and good luck moving forward!

Nchatterji commented 6 years ago

Thanks @cyr3ne for the feedback! I will take you up on the creative liberties (I didn't know we had) and make the next project a lot nicer visually.

I did have a question - in terms of the comment "you do have to adjust the linking to the CSS so that everyone else can see the styling." do you mean create a relative link vs. absolute link?

thecodeduchess commented 6 years ago

I just couldn't see the styling because the css was incorrectly linked. You don't need to add your computer username and all of that, because we can't access that. The css file is contained in the project. Why are you linking out so far?

The next project is Tea cozy, its already styled with a different back ground and fonts, so you dont need to change that. But Colmar academy is VERY plain. So maybe you can work on the capstone design later! :)