EddyShimwa
commented
1 year ago Hello @Ndaboom your work is almost Complete! Let me say Great work So far!!
Highlights
- Good commit history ✔️
- Components were used correctly ✔️
- Props and state used well ✔️
- Used events handlers correctly ✔️
- Lifting state up used ✔️
- Correct Git flow ✔️
- Descriptive PR ✔️
- Good Implementation of work ✔️
Suggestions!
- Kindly use Git flow as it is always recommended for better practices
- Take a look at your
README.mdfile is still empty! Kindly update it with the correct details about the project! in order to make it more clear to anyone who is reading you work!
- As you know,
lintersare important tools that help us maintain code quality and ensure that our code adheres to best practices and standards. While I understand that you may have had your reasons for disabling the linters, I would like to suggest that we keep them enabled to ensure that our code is consistent, maintainable, and easily understandable for other team members.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Edit Todo Feature Through this, I performed the edit todo feature