Ne-Lexa / google-play-scraper

PHP scraper to get data from Google Play
MIT License
75 stars 37 forks source link

Stops working #23

Closed spiritwebdev closed 2 years ago

spiritwebdev commented 2 years ago

Library not working now

sayedsahin commented 2 years ago

because google play has been updated

GrinOleksandr commented 2 years ago

oh no, any ideas on how to fix it?

spiritwebdev commented 2 years ago

guess update regexp\nodes, only html changed :)

Ne-Lexa commented 2 years ago

OK. I will check it and try to fix it

пт, 27 мая 2022 г., 15:51 Sayed Sahin @.***>:

because google play has been updated

— Reply to this email directly, view it on GitHub https://github.com/Ne-Lexa/google-play-scraper/issues/23#issuecomment-1139589967, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIBD52YHOTLVDKHIVI27Z3VMDAODANCNFSM5XEC5M4Q . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Porshe commented 2 years ago

Any updates?

kobyle69 commented 2 years ago

OK. I will check it and try to fix it пт, 27 мая 2022 г., 15:51 Sayed Sahin @.>: because google play has been updated — Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIBD52YHOTLVDKHIVI27Z3VMDAODANCNFSM5XEC5M4Q . You are receiving this because you are subscribed to this thread.Message ID: @.>

Hey @Ne-Lexa any update?

alipeng commented 2 years ago

Any updates?

spiritwebdev commented 2 years ago

nope, its need total rework, html markup changed

alipeng commented 2 years ago

https://github.com/JoMingyu/google-play-scraper/blob/14bb6c3e3748744e3a49d4ed4da7b3915531fbcd/google_play_scraper/constants/element.py#L46

nope, its need total rework, html markup changed

https://github.com/JoMingyu/google-play-scraper/blob/14bb6c3e3748744e3a49d4ed4da7b3915531fbcd/google_play_scraper/constants/element.py#L46

marta-francevna2711 commented 2 years ago

Hope you'll do it soon! @Ne-Lexa

kobyle69 commented 2 years ago

Hope so as well @Ne-Lexa Let us know your Patreon page ;)

Ne-Lexa commented 2 years ago

I will do fixes after the main job. If someone wants to support the project, I can give the USDT TRC-20 address.

kobyle69 commented 2 years ago

I will do fixes after the main job. If someone wants to support the project, I can give the USDT TRC-20 address.

Awesome! And can we contact you on discord?

kobyle69 commented 2 years ago

https://github.com/JoMingyu/google-play-scraper/blob/14bb6c3e3748744e3a49d4ed4da7b3915531fbcd/google_play_scraper/constants/element.py#L46

nope, its need total rework, html markup changed

https://github.com/JoMingyu/google-play-scraper/blob/14bb6c3e3748744e3a49d4ed4da7b3915531fbcd/google_play_scraper/constants/element.py#L46

@alipeng did you manage to fix it on your py library?

spiritwebdev commented 2 years ago

@Ne-Lexa we need an eta!

Really? Are you kiddin? Ne-Lexa do it for free, in his free time. If you so need it superfast - pay someony and they do it for you. Or do it by yourself.

kobyle69 commented 2 years ago

Well, more than happy to pay for that fix if it's possible to get in touch with you @Ne-Lexa )

kobyle69 commented 2 years ago

@Ne-Lexa maybe you can simply merge this: https://github.com/Porshe/google-play-scraper/commit/bb3dd0dc9aaabe51d64e5b81bac6d1493e0ce315 https://github.com/Porshe/google-play-scraper/commit/ab83195eb8a3d233f3c702164cebcb845f4ff2d8

knoy commented 2 years ago

@kobyle69 these changes don't seem to work and are from a very old version

marta-francevna2711 commented 2 years ago

@knoy it works, I checked

knoy commented 2 years ago

@marta-francevna2711 it doesn't seem to work with search. It's also based on an old version ( 0.2.6 ). Getting following error for search :

Fatal error: Uncaught TypeError: Argument 1 passed to Nelexa\GPlay\Scraper\Extractor\AppsExtractor::extractApp() must be of the type array, null given, called in /var/www/foo/vendor/nelexa/google-play-scraper/src/Scraper/ClusterAppsScraper.php on line 56

@kobyle69 this is a free FOSS repo, which Ne-Lexa is not getting paid for. If you want professional support maybe pay the man or don't complain

knoy commented 2 years ago

@kobyle69 you are quite self-entitled, he has absolutely no responsibility to anyone who uses this, least of all when he's getting 0 compensation. Attitudes like yours are the reason people kill FOSS projects or choose not to release them at all. I'd encourage you to read the MIT license this is licensed under

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED

You can always hire another PHP developer to work on this, or you can continue on your pathetic attempt to spam the dev with empty demands while offering nothing in return. I think I know which will be more effective.

marta-francevna2711 commented 2 years ago

@knoy correct. fixed only getAppsInfo function

@kobyle69 omg. just fork it or use https://github.com/pacificresearchalliance/google-play-scraper/blob/ab83195eb8a3d233f3c702164cebcb845f4ff2d8/src/Scraper/AppInfoScraper.php

spiritwebdev commented 2 years ago

@Ne-Lexa we are still waiting... Worst support I have ever encountered in an open-source project

You are most rude and arrogant user at this moment. You din't have money to pay someone to do job for you and shittalking developer who does that for free for anyone on his free time? Just get lost, you are the worst.

knoy commented 2 years ago

@kobyle69 Go ahead do the work then, nothing's stopping you. Or pay a developer to do it. Or do you actually mean you're just going to wait for everyone else to do the work while complaining about a free product and insulting the people doing the work? You didn't "just ask to be given some eta", you've been spamming the dev multiple times a day with your complaints. You're toxic and contributing nothing.

dhmusman commented 2 years ago

@knoy correct. fixed only getAppsInfo function

@kobyle69 omg. just fork it or use https://github.com/pacificresearchalliance/google-play-scraper/blob/ab83195eb8a3d233f3c702164cebcb845f4ff2d8/src/Scraper/AppInfoScraper.php

not working.

Wremeker commented 2 years ago

@Ne-Lexa А нету случайно ERC-20? Спасибо за фикс)

Ne-Lexa commented 2 years ago

@Wremeker, есть ) USDT ERC-20: 0xA6c9776996f16A0C473Dec464A5608a7BCD3BB81

Thanks for support.

Ne-Lexa commented 2 years ago

The problem is solved. Update the version to 0.4