search

Ne-Lexa / php-zip

PhpZip is a php-library for extended work with ZIP-archives.
MIT License
491 stars 60 forks source link

Support for PHP 7.x #78

Open bobdenotter opened 3 years ago

bobdenotter commented 3 years ago
Q A
Library version(s) affected: 4.0.0
PHP version(s): 7.2 and up

Hi,

After the bump to 4.x, there's a hard cutoff for older versions. In our project, we're sticking with Symfony's version support, which means we're supporting PHP 7.2.9 and up. Currently, there's no version of this library that supports both 7.x and 8.x simultaneaously, which means we can't provide a single working setup for our users on different versions of PHP.

Would you consider reverting the dropping of PHP 7.x?

Ne-Lexa commented 3 years ago

Hello.

The main API is almost identical, except for deleting deprecated functional.

Try to specify the version ^3.3 | ^4.0

bobdenotter commented 3 years ago

@Ne-Lexa Hi, thanks for the reply.

I know about the |, but for our use case that doesn't work. Our packaged version needs to be able to resolve the dependencies to one version for the lowest supported version, but that needs to work on the highest supported version.

So, in this case, it'll resolve to 3.3.x, but it'll break for people running on PHP 8.

I-Valchev commented 3 years ago

Hi @Ne-Lexa, indeed like mentioned above it does help a lot of there is one version of the library that supports both 7.x and 8.x. Can we do something to allow you @Ne-Lexa to tag such a release?

Thanks a lot in advance!

bobdenotter commented 3 years ago

Hi,

Not trying to be too insistent, but is there any progress on this? Anything we can do from our end to move it along? :-)