search

NeBula-Autonomy / LOCUS

Robust Lidar Odometry System
MIT License
357 stars 49 forks source link

move core_msgs and frontend_utils #53

Closed yunzc closed 2 years ago

yunzc commented 2 years ago

Since PointCloudMapper depends on core_msgs and frontend_utils, I think it should be moved to the common pkg. Let me know what you guys think. See https://github.com/NeBula-Autonomy/common_nebula_slam/pull/1

BenjaminMorrell commented 2 years ago

I am less up to speed on the different packages - so am happy for @femust to make the decision. I think we can eventually remove that package to be honest. Do you use it in LAMP at all @yunzc ?

yunzc commented 2 years ago

Yeah @BenjaminMorrell PointCloudMapper is also used in LAMP. So right now LOCUS is needed to compile LAMP, which is why I would like to move it to common_nebula_slam

BenjaminMorrell commented 2 years ago

Ah, we should definitely move it to common then.

femust commented 2 years ago

ok let's merge this guys :)