search

NeRdTheNed / MC-TextureGen

A Java program that programatically generates textures generated by certain versions of Minecraft at runtime, and then saves them to individual files.
The Unlicense
12 stars 1 forks source link

Comment typo in NetherPortalGenerator.java #34

Closed muzikbike closed 10 months ago

muzikbike commented 1 year ago

I believe line 87 should say "Alpha", not "Aplha".

muzikbike commented 1 year ago

On the topic of nether portals, I have a second comically small thing to nitpick: the release notes for v1.3.0 say that the generated nether portal textures match those used in modern versions of the game. However, according to https://minecraft.fandom.com/wiki/Procedural_animated_texture_generation/Nether_portals there should be a subtle difference - the alpha channel should be the exact same across all pixels in the modern texture, as opposed to being tied to the blue channel in prior versions. Looking closely at the comment I added to #19 I think I can see a minor distinction, as the 1.4.7 texture does appear slightly more translucent in the less purple areas than in 1.5, though this isn't a rigorous comparison by any means. I understand this is a rather pointless thing to be asking about, but I assume that the v1.3.0 release statement was just a result of eyeballing the texture since everything else is mostly accurate?

I might try comparing generated frames with individual frames cut out of the official texture some time soon just to be absolutely sure.

muzikbike commented 1 year ago

Actually, turns out that probably isn't the case: https://minecraft.fandom.com/wiki/Procedural_animated_texture_generation/Nether_portals?curid=169053&diff=2215120&oldid=2215009