search

NeRdTheNed / RetroWrapper

An attempt to implement community ideas and ease of use tweaks for RetroWrapper
MIT License
20 stars 3 forks source link

Capes are not wrapped? #19

Closed NeRdTheNed closed 1 year ago

NeRdTheNed commented 3 years ago

RetroWrapper does not handle cape URLs. The fix would be similar to the skin fix. Needs more investigation.

NeRdTheNed commented 3 years ago

Although this was theoretically fixed in commit 272cc65daafddab8909c827e4ac4b9f5959dba91, the versions of Minecraft I tested simply never tried to load the cape. I confirmed that the cape download logic worked by wrapping the link that OptiFine uses for its own cape system (https://optifine.net/capes/(player name).png), which works. (Note to self: try wrapping OptiFine capes if the player doesn't have a vanilla cape?) I have no clue why vanilla versions don't try to load the cape. I probably haven't tested enough, but I can't think of anything else to try... I guess this issue will stay open for a while.

NeRdTheNed commented 1 year ago

With the help of some jar modding, I've determined that Minecraft isn't properly seeing the patch for capes, despite it working in the exact same way that the skin patch works. Here's Beta 1.7.3:

Screen Shot 2022-11-08 at 12 13 37 pm

The correct output should be that both URLs are redirected to 127.0.0.1.