NeTEx-CEN / NeTEx

NeTEx is a CEN Technical Standard for exchanging Public Transport schedules and related data.
http://netex-cen.eu
GNU General Public License v3.0
83 stars 39 forks source link

Values in AllModesEnumeration vs ContinuousModeEnumeration #45

Open skinkie opened 5 years ago

skinkie commented 5 years ago

In ContiniousModes we are using walk and cycle. In AllModesEnumeration we are using foot and bicycle. This should be made more consistent.

Aurige commented 4 years ago

Yes, as explained in Brussels on Nov 12th, there will be very soon an extension for new modes where we should be able to manage this.

ue71603 commented 2 years ago

Seems it was notsolved in new modes.
@Aurige How do we continue?

<xsd:simpleType name="ContinuousModeEnumeration">
    <xsd:annotation>
        <xsd:documentation>Allowed values for continuous MODES of transport applicable to private and non-timetabled transport.</xsd:documentation>
    </xsd:annotation>
    <xsd:restriction base="xsd:NMTOKEN">
        <xsd:enumeration value="walk"/>
        <xsd:enumeration value="car"/>
        <xsd:enumeration value="taxi"/>
        <xsd:enumeration value="cycle"/>
        <xsd:enumeration value="drt"/>
        <xsd:enumeration value="movingWalkway"/>
        <xsd:enumeration value="through"/>
        <xsd:enumeration value="ski"/>
        <xsd:enumeration value="skate"/>
    </xsd:restriction>
</xsd:simpleType>

<xsd:simpleType name="AllModesEnumeration">
    <xsd:annotation>
        <xsd:documentation>Allowed values for r MODES: TPEG pti_table 01.</xsd:documentation>
    </xsd:annotation>
    <xsd:restriction base="xsd:NMTOKEN">
        <xsd:enumeration value="all"/>
        <xsd:enumeration value="unknown"/>
        <xsd:enumeration value="air"/>
        <xsd:enumeration value="bus"/>
        <xsd:enumeration value="trolleyBus"/>
        <xsd:enumeration value="tram"/>
        <xsd:enumeration value="coach"/>
        <xsd:enumeration value="rail"/>
        <xsd:enumeration value="intercityRail"/>
        <xsd:enumeration value="urbanRail"/>
        <xsd:enumeration value="metro"/>
        <xsd:enumeration value="water"/>
        <xsd:enumeration value="cableway"/>
        <xsd:enumeration value="funicular"/>
        <xsd:enumeration value="lift"/>
        <xsd:enumeration value="snowAndIce"/>
        <xsd:enumeration value="taxi"/>
        <xsd:enumeration value="selfDrive">
            <xsd:annotation>
                <xsd:documentation>See pti12_x.</xsd:documentation>
            </xsd:annotation>
        </xsd:enumeration>
        <xsd:enumeration value="foot"/>
        <xsd:enumeration value="bicycle"/>
        <xsd:enumeration value="motorcycle"/>
        <xsd:enumeration value="car"/>
        <xsd:enumeration value="shuttle"/>
        <!-- NOT IN tpeg -->
        <!-- NOT IN tpeg -->
    </xsd:restriction>
</xsd:simpleType>
Aurige commented 2 years ago

do we have a ContinuousModeEnumeration in NeTEx ?

ue71603 commented 2 years ago

It exists in the "next" branch, but it is absolutely nowhere used. What do we do? Delete it in next?

Aurige commented 2 years ago

It has to be discussed, at minimum: I'm not happy with enum values like "drt" or "through" for example ... I would prefer to first finalise a discussion at Transmodel level, in order to sync SIRI and NeTEx afterword

skinkie commented 2 years ago

Next may contain new stuff. but if we already know it should be removed, lets do so.

ue71603 commented 2 years ago

I think at it is nowhere referenced, that we remove it from the model for now and add it after the discussion, when synchronized. Or we only comment it out

trurlurl commented 2 weeks ago

ContinuousModeEnumeration has been removed from the code in the meantime, some spooky day in november - see netex_mode_support.xsd:

<Date><Modified>27-11-26</Modified>New Modes;
  Drop ContinuousModes 
</Date>

So, this problem is solved.

Also, enum value walk doesn't occur in the code any more, for cycle see below. Here remains a little problem to be discussed and at least pedalCycle is awaiting a description. What is the use of cycle, would it be used to indicate that both pedalCycle and eCycle can be transported? Is it really needed?

<xsd:simpleType name="PortableVehicleCategoryEnumeration">
        <xsd:annotation>
            <xsd:documentation>Allowed values for Portable VEHICLE types. +V2.0</xsd:documentation>
        </xsd:annotation>
        <xsd:restriction base="xsd:string">
            <xsd:enumeration value="scooter"/>
            <xsd:enumeration value="eScooter"/>
            <xsd:enumeration value="cycle"/>
            <xsd:enumeration value="pedalCycle">
                <xsd:annotation>
                    <xsd:documentation/>
                </xsd:annotation>
            </xsd:enumeration>
            <xsd:enumeration value="eCycle"/>`
Aurige commented 1 week ago

My understanding is that pedalCycle means non-motorised cycle ...

but most eCycle had pedals, so that's true that it is confusing. to be validated by the group

trurlurl commented 1 week ago

@Aurige This makes sense in my view, too. I'm going to add the descriptions.

But one thing remains to be clarified: can / should we rename cycle to bicycle? This is the only occurrence of "cycle", and I think that typical uses of "bicycle" don't mind whether it is a conventional or a motorised bicycle.