search

NeTEx-CEN / NeTEx

NeTEx is a CEN Technical Standard for exchanging Public Transport schedules and related data.
http://netex-cen.eu
GNU General Public License v3.0
80 stars 39 forks source link

fareStructureFactor vs fareStructureFactors? #469

Open skinkie opened 1 year ago

skinkie commented 1 year ago

https://github.com/NeTEx-CEN/NeTEx/blob/master/xsd/NX.xsd#L139

Aurige commented 1 year ago

fareStructureFactors for sure

skinkie commented 1 year ago

fareStructureFactors for sure

Should it then also be fareStructures?

https://github.com/NeTEx-CEN/NeTEx/blob/master/xsd/NX.xsd#L254

Aurige commented 1 year ago

Most probably, but only for consistency reasons ... this NX.xsd is just for information (not for use), so provided that you have either XXX either XXXs, the information is there, but consistency is always good !

skinkie commented 1 year ago

If it is actually documentation, it should not be in that folder for my perspective.

Aurige commented 1 year ago

Yes you are fully right

ue71603 commented 9 months ago

@skinkie can we close this one?

skinkie commented 9 months ago

@ue71603 if you add https://github.com/NeTEx-CEN/NeTEx/commit/258c905a6804cb73afd05c68907d8d7e30e6f59e

ue71603 commented 8 months ago

@skinkie are those changes already committed? and in which PR? If so, can you close this issue?

ue71603 commented 4 months ago

Pls close, if done or add PR.