search

NeVeSpl / RevitDBExplorer

Interactive Revit database exploration tool to view and edit BIM element parameters, properties and relationships.
Apache License 2.0
179 stars 40 forks source link

Feature: add inline unit conversion #1

Closed NicoBrown closed 1 year ago

NicoBrown commented 2 years ago

Could a column be added to convert the Revit units into whatever the model is in for readability?

image

Happy to do it and open a pull request if you think its a good idea?

NeVeSpl commented 2 years ago

What would you say about placing that information in a tooltip?

image

That already is implemented, but there is a bug here: https://github.com/NeVeSpl/RevitDBExplorer/blob/86acb0ba5d84e8b71b910f5d8bebc0853672cc87/sources/WPF/Converters/FeetToMetersConverter.cs#L16

should be typeof(double).GetCSharpName() instead "Double"

PR welcome to fix that, or/and expand the tooltip with more unit conversions.

NicoBrown commented 2 years ago

I'll take a look at it now and possibly add some more conversions.

If its alright, can I start a Contributions.md at the same time?

NeVeSpl commented 2 years ago

sure, you can do every not time-consuming change you want without asking, we will be thinking about its fate during PR review.