Fix scroll progress percent

NeXTs / Clusterize.js

Tiny vanilla JS plugin to display large data sets easily

https://clusterize.js.org

MIT License

7.22k stars 412 forks source link

Fix scroll progress percent #181

Closed FeehGb closed 2 years ago

FeehGb commented 3 years ago

Scroll percent fix

The scroll progress was returning the wrong value when reach the bottom off element;

/* - */  return this.options.scroll_top / (rows.length * this.options.item_height) * 100 || 0;
/* + */  return this.options.scroll_top / (self.scroll_elem.scrollHeight - self.scroll_elem.clientHeight) * 100 || 0;

NeXTs commented 3 years ago

"The scroll progress was returning the wrong value when reach the bottom off element"

Hello, do you have demo reproducing the problem?

FeehGb commented 3 years ago

take a look https://codepen.io/FeehGb/pen/wvgzjRj

FeehGb commented 3 years ago

I realized that opts.item_height = node.offsetHeight return wrong height; I fixed height 30px; offeset height return 31px; I dont know why In my file i created the item_height as options to fix it;