search

NeXTs / Clusterize.js

Tiny vanilla JS plugin to display large data sets easily
https://clusterize.js.org
MIT License
7.22k stars 412 forks source link

added IE 8 support #9

Closed dhenson02 closed 9 years ago

dhenson02 commented 9 years ago

I think IE 8 support is pretty standard throughout the industry since companies don't pay for upgrades if they can get away with it.

Here's a demo if you have IE 8 and want to try: http://codepen.io/lacoolj/full/RPPqay/

See issue #10 for extra info.

NeXTs commented 9 years ago

Hi Deryck, why you closed the pull request?

dhenson02 commented 9 years ago

Because with the exception of load time, supporting IE 8 provides no improvement on current capabilities of the browser. That and when scrolling DOM can't keep up with the JS so the rows disappear until stopping (though this may be partly because of my testing in a virtual machine). If you can test on a Windows or Mac PC and you don't have this issue I'll re-fork and pull again (and add the other small changes I forgot to put last time - revisit the codepen for specifics).

NeXTs commented 9 years ago

Exception of demo page load time? This occurs because the insert 50000 rows in the table. DOM can't keep up fast scrolling elements, that's true, but rows appears once stop scrolling, that's fine for so ancient browser. btw it seems fine when scroll by mouse wheel. I decided to include ie8 support as it will cost only extra 0.07kb, so pull again please