Neamar / KISS

Lightning fast, open-source, < 250kb Android launcher
https://kisslauncher.com/
GNU General Public License v3.0
2.93k stars 579 forks source link

Widget max size not checked and pop-up menu displays out of screen #1871

Open password123123123 opened 2 years ago

password123123123 commented 2 years ago

Describe the bug The widget control popup menu display out of screen after some widget manipulation.

To Reproduce

  1. Create a widget (e.x. Digital clock)
  2. Use the pop-up menu to increase it size to max
  3. Keep pressing "increase size" - widget size will not change, but If you wish to decrease it later you'll need to press "decrease" many times
  4. After it when you exit widget menu and enter it again, the pop-up menu will bit displayed out of bound

Expected behavior The "increase widget size" greyed out when size is max.

Screenshots Please add screenshots to help explain your problem. You can upload images directly to Github, please do not use an external website to host your images.

Additional information

Additional context Add any other context about the problem here.

marunjar commented 2 years ago

The widget changes, you can see this if you add another widget after e.g. Digital Clock. This is because KISS doesn't have any influence on how content of widget is shown, e.g. Digital Clock shows time always on top of widget independent of size.

There is indeed a max widget size which is available only from android S and also only for widgets which defines it. But height of all other widgets can be increased indefintely.

I created a #1872 which adds additional check for max widget size, which we can merge once KISS uses compileSdkVersion 31

ad 4: KISS has no impact on the popup menu, which is layed out by Android itself. This can't be fixed.