issue displaying a secific icon pack

[bastschonet]

Describe the bug Issue displaying a specific icon pack. In my case Iconpack "LineX White" (from: JustNewDesigns) Does not occur with others icon packs i use e.g. "Ghost" (same developer)

To Reproduce A pattern (circle, hexagon) will be drawn around the icons. The icons got reduced by size. Pattern could change randomly.

Expected behavior No pattern should be drawn. If not enabled in settings ;-)

Screenshots

Additional information

• App version: 3.16.10
• App installed via: (f-droid, Play Store, debug APK): PlayStore

Additional context

[TBog]

I was finally able to get the apk of the icon-pack you mentioned. It seems to have 24 different background options for the icons. Right now the launcher chooses one randomly each time. I don't see this as a bug.

Having the user choose a background could be a cool new feature.

[marunjar]

I saw similar behaviour already when debugging something with Juno Icon Pack. At least the randomness can be fixed easily.

If we have something static about a result, we can use this to calculate "semi" random background which will never change. e.g. AppPojo.getComponentName or something else. With this we may calculate always same background for same result: backImageInd = (somethingStatic.hashCode() & 0x7fffffff) % backImages.size()

[TBog]

I think the idea is to let the user choose the same background for all the icons.

The hash modulo is great if you want to keep the randomness without having it change.

[sundayLOOKplants]

Adding to this (does not seem distinct enough to open a new issue): All Arcticons Dark icons appear as blank white circles after yesterday's F-Droid update.

[marunjar]

Adding to this (does not seem distinct enough to open a new issue): All Arcticons Dark icons appear as blank white circles after yesterday's F-Droid update.

@sundayLOOKplants with latest release, icon shape is taken from system if applicable. This in combination with Force icon background enabled and all white icons results in mentioned behaviour. For details see #1828 and #1855

[lthExeter]

Have a similar issue with retro mode - neon icon pack on my Xperia 10 IV, the icons are all defaulting to have a circle around them, when it should just be the icon. It is working fine on my tablet (tab s8+), spoken to icon pack dev it looks to be a launcher issue. An option for no background shape under icons as a manual override might fix?

[moertel]

Hey, developer of the Retro Mode icon pack here. @Neamar and/or @marunjar could this be due to a different understanding of how provided icon backgrounds are supposed to work?

Nova, Action Launcher (and others) only use the provided iconupon, iconmask and iconback attributes in the XML when the icon itself is not themed. The desired effect of it is the one in this screenshot. It might not be perfectly themed but at least blends in better:

KISS, however, applies the attributes to all icons, no matter whether themed or not:

Tweaking the settings in KISS seems to have no effect, at least for me; the shaping is always there. Happy to provide you with a promo code to test it if necessary.

[TBog]

The initial implementation had some bugs and I for one never checked more than a couple of IconPacks. I checked open source packs and some that users reported problems with. AFAICT the fix is easy. We could also add a legacy mode switch (or some other better name).

[marunjar]

@moertel @TBog this problem is already fixed on master with #2090, related bug was #2088

[moertel]

Ah, thanks @marunjar. I did give this a thorough search beforehand (I swear) but didn't stumble upon that PR. I see the current release on Play Store is version 3.20 (published 15 March). Do you have a timeline when this fix might hit the store?

[marunjar]

no idea, releases are up to @Neamar

[Neamar]

Just pushed it to the beta channel on the store :)

[moertel]

Thanks a lot! I can confirm that the issue is fixed in the beta! :)

[marunjar]

@bastschonet pattern should not be drawn for themed icons any more. Can you confirm with your "LineX White" icon pack?

[bastschonet]

Hi marunjar, the icon pack is shown properly. Pattern will not be drawn around the icons. Thanks!

On Thu, 2 Nov 2023 at 15:58, marunjar @.***> wrote:

@bastschonet https://github.com/bastschonet pattern should not be drawn for themed icons any more. Can you confirm with your "LineX White" icon pack?

— Reply to this email directly, view it on GitHub https://github.com/Neamar/KISS/issues/1996#issuecomment-1790898843, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATNJJL2TPEMNKQ3MHCU54TLYCOYKBAVCNFSM6AAAAAARP7LMO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQHA4TQOBUGM . You are receiving this because you were mentioned.Message ID: @.***>

[marunjar]

fixed with #2090