search

Neamar / KISS

Lightning fast, open-source, < 250kb Android launcher
https://kisslauncher.com/
GNU General Public License v3.0
2.99k stars 582 forks source link

Problem displaying icons #2088

Closed soerooroo closed 1 year ago

soerooroo commented 1 year ago

Describe the bug Some Icon Packs are not displayed right e.g. Lanting, Crayon, OwLine, Nothing, MinimalO, Taco Taco, Vertical IconPack, droidOne UI, Nexa and some others too. I found an issue where it was mentioned that an icon pack offers some different backgrouds/borders, but compared with the behaviour in other Launchers this borders/backgrounds are only supposed to be used if the icon pack offers no specific icon for this APP. If there is an icon provided it should be used as is. MinimalO has no border but it displays icons not in the icon pack with less saturation, but with kiss also apps with provider icons are again less saturatated what looks odd. Nexa and Phantom are free icon packs to test. With Nexa the Icons are made smaller and habe a border which is only thought to be the case if no icon is provider by the icon pack.

To Reproduce Steps to reproduce the behaviour: Just install Nexa Icons use them with e.g. Lawnchair and with KISS you'll See the difference.

Expected behavior Backgrounds and borders vor other modifications should only be used if the icon pack does not provide an icon for an APP.

Screenshots Screenshot_2023-04-03_09-44-37~2 Expected

Screenshot_2023-04-03_09-46-29~2 Currently the case

Additional information

marunjar commented 1 year ago

This looks odd, but expected behaviour also seems wrong to me. maybe just a bug when resizing icon or background.

mask, background and overlay must be applied to all icons of an icon pack. unfortunately i cannot check documentation anymore as adwthings.com is down not for some years. anybody has this somewhere?

soerooroo commented 1 year ago

@marunjar I understand if the expected looks wrong but it is the way it is advertised in the Screenshots on the PlayStore.

In other launchers Lawnchair is only one example the reduction in size of the icon in front of the icon shaped colored background is only applied if there is no specific icon for the app inside the icon pack in this way these applications look better in place. But if an provider icon is again reduced in size that looks wrong.

I love KISS but would love to have more freedom chosing an icon pack.

For me it is also great if there is a switch in settings how it should be so everybody can choose his preference.

soerooroo commented 1 year ago

Screenshot_20230405-205929~2 KISS

Screenshot_20230405-205936~2 PlayStore

marunjar commented 1 year ago

@soerooroo you are right, just found https://web.archive.org/web/20150510021358/http://adwthings.com/launcher/adw-theming-guide/ background, overlay and mask must be applied only to icons not provided by icon pack.