fix icon packs with mask

Neamar / KISS

Lightning fast, open-source, < 250kb Android launcher

https://kisslauncher.com/

GNU General Public License v3.0

2.99k stars 582 forks source link

fix icon packs with mask #2090

Closed marunjar closed 1 year ago

marunjar commented 1 year ago

fixes #2088 and hopefully #1863
do not apply icon pack mask, background, ... to icons from icon pack
apply icon pack mask only to icons not from icon pack
harden parsing of scale tag: first read from attribute "factor" then read first attribute
remove unnecessary conversion of adaptive drawables

syphyr commented 1 year ago

I get an error when building:

Could not load the value of field `compilerArgumentProviders` of `org.gradle.api.tasks.compile.CompileOptions` bean found in field `capturedArgs` of `java.lang.invoke.SerializedLambda` bean found in field `spec` of `org.gradle.api.internal.tasks.execution.SelfDescribingSpec` bean found in task `:app:compileDebugJavaWithJavac` of type `org.gradle.api.tasks.compile.JavaCompile`.

marunjar commented 1 year ago

I get an error when building:

Could not load the value of field `compilerArgumentProviders` of `org.gradle.api.tasks.compile.CompileOptions` bean found in field `capturedArgs` of `java.lang.invoke.SerializedLambda` bean found in field `spec` of `org.gradle.api.internal.tasks.execution.SelfDescribingSpec` bean found in task `:app:compileDebugJavaWithJavac` of type `org.gradle.api.tasks.compile.JavaCompile`.

Seems to be a problem with your local branch/setup only, build and checks for last commit (5fd1319) are passing: 2023-04-06 23_50_23-marunjar_KISS at fix_icon_pack_with_mask – Mozilla Firefox

syphyr commented 1 year ago

I get an error when building:

Could not load the value of field `compilerArgumentProviders` of `org.gradle.api.tasks.compile.CompileOptions` bean found in field `capturedArgs` of `java.lang.invoke.SerializedLambda` bean found in field `spec` of `org.gradle.api.internal.tasks.execution.SelfDescribingSpec` bean found in task `:app:compileDebugJavaWithJavac` of type `org.gradle.api.tasks.compile.JavaCompile`.

Seems to be a problem with your local branch/setup only, build and checks for last commit (5fd1319) are passing: 2023-04-06 23_50_23-marunjar_KISS at fix_icon_pack_with_mask – Mozilla Firefox

same error when building only marunjar:fix_icon_pack_with_mask with no other commits

syphyr commented 1 year ago

i am building from shell with only ./gradlew assemble

syphyr commented 1 year ago

sorry, the problem was my local branch. git clean -fdx fixed the error.

marunjar commented 1 year ago

I'm merging this now. I'm using the fix for about 3 weeks now with Juno icon pack on my device and there were no errors.