search

Neamar / KISS

Lightning fast, open-source, < 250kb Android launcher
https://kisslauncher.com/
GNU General Public License v3.0
2.99k stars 582 forks source link

App shortcuts can't be added to favorites #2112

Closed devnoname120 closed 1 year ago

devnoname120 commented 1 year ago

Bug description

Starting app shortcuts from the favorites bar is very useful.

For example I only use Instagram for messaging so I usually open it through the Instagram: Direct native shortcut that comes with Instagram.

This is especially important to me as I have ADHD so I get distracted VERY easily. Having to go through the home page with all the shiny attention-grabbing posts is basically a death sentence for my productivity and I instantly forget that I wanted to open my messages in the first place.

Opening this app shortcut works great but for some reason the Add to favorites menu item doesn't appear when I long press the shortcut. I have the same issue with most app shortcuts (but not all!).

I can confirm that the Add to favorites appears and works for all apps however (except their shortcuts of course).

To reproduce

Steps to reproduce the behavior:

  1. Install Instagram.
  2. Search for Instagram.
  3. Long press the Instagram: Direct shortcut.
  4. The KISS popup menu only provides the following options:
    • Add or edit tags.
    • Remove from history.

Expected behavior

The KISS popup menu should have the Add to favorites entry just like apps.

What I tried

  1. Go to KISS menu > KISS settings > Search settings > Regenerate all app shortcuts.
  2. Search for Instagram.
  3. Long press the Instagram: Direct shortcut.
  4. The KISS popup menu still doesn't contain the Add to favorites entry.

Screenshots

Screenshot_20230604-101056_KISS launcher.png

https://github.com/Neamar/KISS/assets/2824100/5d6db8b2-0883-4a62-b12f-65716b640939

Additional information

Additional context

It used to work in the past on my phone but it stopped working a few months ago. So it may be a regression from a KISS update (not sure which if that's the case). Edit: v3.16 is probably the last version where it works.

marunjar commented 1 year ago

This shortcut seems to be dynamically created by Instagram and can be changed/removed anytime. If such dynamic shortcuts are in favorites and Instagram decides to change it, the shortcut can

It's similar to #2037 and we can't really do anything useful here. See also https://github.com/Neamar/KISS/issues/2037#issuecomment-1373747709

devnoname120 commented 1 year ago

Some shortcuts seem to work. For example I can create a shortcut to a URL using the Shortcut to URL app. The shortcut appears in KISS and I can add it to favorites without any issues.

How comes this shortcut can be added to favorites without issues?

With regard to disappearing shortcuts, I agree that it can be pretty annoying. But in my experience this doesn't happen very frequently and I can just add the shortcut again to the favorites in order to fix it.

We could also have some heuristics as mitigation strategies. For example if a shortcut disappears we can look for another shortcut from the same app that has the same title/description as the now-defunct shortcut.

In general, for my use case the benefits vastly outweigh the limitations. If this feature isn't for everyone, what would you think about adding an option in the KISS settings to allow/disallow adding shortcuts to favorites?

Unfortunately this feature is an absolute must-have for me so I will have to stick to v3.16 unless/if it's reintroduced in a later version... :(

marunjar commented 1 year ago

@devnoname120 to add a dynamic shortcut to favorites, you must now pin it to kisss first. This prevents shortcut from beeing changed or removed by app. In second step you can add this pinned shortcut to favorites as you like.

devnoname120 commented 1 year ago

@marunjar Thank you for your explanations. Please note this limitation: https://github.com/Neamar/KISS/pull/2120#issuecomment-1634630350