Neamar / KISS

Lightning fast, open-source, < 250kb Android launcher
https://kisslauncher.com/
GNU General Public License v3.0
2.98k stars 582 forks source link

BUG with Icon Pack1 #2192

Open Livio78 opened 1 year ago

Livio78 commented 1 year ago

Hi, when I use an ICON PACK with Kiss Launcher and change an icon to a custom icon and then clear the KISS LAUNCHER cache, the custom icon returns to the default icon pack. For me it's a BUG and needs to be fixed. I hope it will be fixed soon with an update or that someone will show me the solution for this BUG. I hope to receive a response soon. Thank you

TBog commented 1 year ago

Why do you clear the launcher cache? That's where the custom icons are stored. I hope to receive a response soon. Thank you!

Livio78 commented 1 year ago

Thank you Il sabato 21 ottobre 2023 alle ore 18:48:10 CEST, TBog @.***> ha scritto:

Why do you clear the launcher cache? That's where the custom icons are stored. I hope to receive a response soon. Thank you!

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

ypnos commented 10 months ago

To be honest, user settings are expected to be persistent. Clearing cache should not change the behavior of an app except performance.

Storing this user setting in the cache might also be the reason why it randomly gets lost on some devices. Android can trim caches when disk space is running low. See pm trim-caches command.

TBog commented 10 months ago

To be honest, user settings are expected to be persistent.

Clearing an app's cache does not clear the settings. The settings data (including shared preferences) is stored in a different place than the app's cache. You need to "clear data" to clear out the shared preferences.

Custom icons are stored in the cache because it doesn't require storage permission and in case the user needs disk space we can easily revert to the default icons.

ypnos commented 10 months ago

Thank you for your reply. In my point of view, when I set a custom icon for an app, that is a user setting. Same as adding tags to an app or renaming an app. These are three options in the same pop up menu and setting a custom icon is right in the middle.

How should a user expect that one of these things is persisted as a setting, while the other is not? I understand that you need to store the icon but as a user, I wouldn't even expect that (I just select an icon from a list of already available ones).

I would expect you can store icons in app data instead of app cache without extra permissions, but I really have no clue :-)

Thank you for your consideration.