search

Neamar / KISS

Lightning fast, open-source, < 250kb Android launcher
https://kisslauncher.com/
GNU General Public License v3.0
2.99k stars 582 forks source link

disabled icons #2252

Closed marunjar closed 6 months ago

marunjar commented 9 months ago

grey out icons of disabled apps (#1265)

syphyr commented 9 months ago

I tested this on Nougat and ran into the following issue:

02-14 01:10:46.562 28995 29210 E AndroidRuntime: FATAL EXCEPTION: AsyncTask #4
02-14 01:10:46.562 28995 29210 E AndroidRuntime: Process: fr.neamar.kiss, PID: 28995
02-14 01:10:46.562 28995 29210 E AndroidRuntime: java.lang.RuntimeException: An error occurred while executing doInBackground()
02-14 01:10:46.562 28995 29210 E AndroidRuntime:    at android.os.AsyncTask$3.done(AsyncTask.java:325)
02-14 01:10:46.562 28995 29210 E AndroidRuntime:    at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:354)
02-14 01:10:46.562 28995 29210 E AndroidRuntime:    at java.util.concurrent.FutureTask.setException(FutureTask.java:223)
02-14 01:10:46.562 28995 29210 E AndroidRuntime:    at java.util.concurrent.FutureTask.run(FutureTask.java:242)
02-14 01:10:46.562 28995 29210 E AndroidRuntime:    at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:243)
02-14 01:10:46.562 28995 29210 E AndroidRuntime:    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
02-14 01:10:46.562 28995 29210 E AndroidRuntime:    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
02-14 01:10:46.562 28995 29210 E AndroidRuntime:    at java.lang.Thread.run(Thread.java:761)
02-14 01:10:46.562 28995 29210 E AndroidRuntime: Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.graphics.drawable.Drawable.setColorFilter(android.graphics.ColorFilter)' on a null object reference
02-14 01:10:46.562 28995 29210 E AndroidRuntime:    at fr.neamar.kiss.utils.DrawableUtils.setDisabled(DrawableUtils.java:22)
02-14 01:10:46.562 28995 29210 E AndroidRuntime:    at fr.neamar.kiss.result.AppResult.getDrawable(AppResult.java:53)
02-14 01:10:46.562 28995 29210 E AndroidRuntime:    at fr.neamar.kiss.result.Result$AsyncSetImage.doInBackground(Result.java:42)
02-14 01:10:46.562 28995 29210 E AndroidRuntime:    at android.os.AsyncTask$2.call(AsyncTask.java:305)
02-14 01:10:46.562 28995 29210 E AndroidRuntime:    at java.util.concurrent.FutureTask.run(FutureTask.java:237)
02-14 01:10:46.562 28995 29210 E AndroidRuntime:    ... 4 more
syphyr commented 8 months ago

The fatal exception on Nougat is now fixed. Thanks.

syphyr commented 7 months ago

Thanks for rebase but this is still conflicting with https://github.com/Neamar/KISS/pull/2251/commits/3e05eb7af9317a164a78c3c5d864ca06b8dc2104

marunjar commented 7 months ago

Thanks for rebase but this is still conflicting with 3e05eb7

Will check when it's ready for merge. It should not matter for now, both PR are not ready yet.