Neamar / KISS

Lightning fast, open-source, < 250kb Android launcher
https://kisslauncher.com/
GNU General Public License v3.0
2.93k stars 579 forks source link

Feature/bug (?): please do not repopulate default tags #2293

Open skedastically opened 4 months ago

skedastically commented 4 months ago

Not sure if bug or feature.

Describe the issue

I want to use KISS without any default tags at all.

However, KISS automatically re-adds them (e.g. clock, message, call) when they're not explicitly configured by the user. This makes configuring with an empty tag field ("__tags":{}) not possible.

To Reproduce

  1. Export settings and tags
  2. Edit the exported JSON so that "__tags":{}
  3. Import settings and tags. No tags show up after this.
  4. Restart KISS, default tags are visible in the launcher again.

Expected behavior

In my opinion, all tags should be made on an opt-in basis. So I expect no tags to be created with such a configuration.

Workaround

Currently, to disable tags, the user must delete them one by one. This will show up as an empty tag string for said app (e.g. "__tags":{{fr.neamar.kiss\/fr.neamar.kiss.MainActivity:""}} ). However, this mean you have to manually edit new installed apps that trigger default tags too. This app-by-app process also make replicating configs between different users more difficult.

Choosing to hide tag is not an option as it'd show up in search again.

Proposed solution

  1. Unless on a fresh install, do not auto-add default tags.
  2. Instead, add settings option to "Re-add default tags", probably somewhere in Advanced settings.

Screenshots

N/A

Additional information

Additional context

N/A

marunjar commented 4 months ago

I think this won't be changed. What is described here is intended behaviour, also tags are not repopulated if removed through UI.

Please keep in mind, that export/import of settings is thought for saving and restoring settings. If messing around with this json, it will result in undefined or unexpected behaviour as you can see. In the worst case modified settings contain invalid data and KISS simply crashes or can't even be started any more.

Not sure if bug or feature.

Describe the issue

I want to use KISS without any default tags at all.

Tags can already be removed/added. As you found already here some apps are pre-tagged, but you can easily edit or remove these too. This is a one-time action, and there are not that many apps that have tags by default.

However, KISS automatically re-adds them (e.g. clock, message, call) when they're not explicitly configured by the user. This makes configuring with an empty tag field ("__tags":{}) not possible.

To Reproduce

1. Export settings and tags

2. Edit the exported JSON so that `"__tags":{}`

This is nothing that should be edited manually.

3. Import settings and tags. No tags show up after this.

4. Restart KISS, default tags are visible in the launcher again.

Once all data has been removed, KISS behaves as if it had been reinstalled.

Expected behavior

In my opinion, all tags should be made on an opt-in basis. So I expect no tags to be created with such a configuration.

Workaround

Currently, to disable tags, the user must delete them one by one. This will show up as an empty tag string for said app (e.g. "__tags":{{fr.neamar.kiss\/fr.neamar.kiss.MainActivity:""}} ). However, this mean you have to manually edit new installed apps that trigger default tags too. This app-by-app process also make replicating configs between different users more difficult.

This is how it is supposed to work, if there is no such entry KISS must assume that it is a new app and add default tags if applicable.

Choosing to hide tag is not an option as it'd show up in search again.

Proposed solution

1. Unless on a fresh install, do not auto-add default tags.

This is already the case, KISS recognizes if app has set some tags. By importing "__tags":{} you reset everthing and KISS handles tags for apps then like it's done on fresh install. Same as when you clear KISS app data, it behaves like when it was just installed.

2. Instead, add settings option to "Re-add default tags", probably somewhere in Advanced settings.

Screenshots

N/A

Additional information

* App version: 3.21.1

* App installed via: f-droid

Additional context

N/A

skedastically commented 3 months ago

Thank you, I now understand that this is the expected behavior. Though I do find the feature to be a bit of a bloat - KISS should only add tags when explicitly told to. It's just my opinion and I'll make do with such a feature not being added for now.