search

Neamar / teamward-client

Android client for Teamward app
https://play.google.com/store/apps/details?id=fr.neamar.lolgamedata
MIT License
16 stars 5 forks source link

Tips about your account should be filtered #25

Open kanytu opened 6 years ago

kanytu commented 6 years ago

When showing the game tips, I get tips about my own account ex: One Trick - Careful about this player because he knows the champion quite well.

hint: OtpTipBuilder.java:21

Neamar commented 6 years ago

Hey,

I figured it might be interesting because it gives you an idea of "what is a one trick pony", since you can compare with yourself. I know why I might be a Katarina OTP, and I can assume that any other OTP will have the same investment on their champion.

Not sure it makes sense, to be fair.

kanytu commented 6 years ago

I agree it's interesting to show that. But in my option the string should be changed then. For example, my team mates can be OTP but why should I "be careful" about that? You understand?

It's cool to show your own OTP tip but the string sometimes can be misleading. I keep getting OTP tips for my team mates saying to be careful and I always need to double check if they are on my team or not. Maybe a border for enemy or team mate, along with a different string.

It's just a suggestion tho :)

Neamar commented 6 years ago

You're right, displaying a border with team color would be quite helpful :)

I'll try to have a look this weekend, unless you wanna try? PR are welcome!

kanytu commented 6 years ago

Good to know you're accepting PR :) I'll see if I have the time to give you a hand.

Neamar commented 6 years ago

Hi there! Do you have time for this? Otherwise I'll add it to my backlog, but I'm working on something big already so it'll take some time!

On Mon, Nov 20, 2017 at 2:25 PM Pedro Oliveira notifications@github.com wrote:

Good to know you're accepting PR :) I'll see if I have the time to give you a hand.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Neamar/teamward-client/issues/25#issuecomment-345694509, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgxDBTR36rkEnYjQBb5CnuTJaN7pcYaks5s4X3OgaJpZM4QjCg6 .

kanytu commented 6 years ago

Hey!

Yes I can do it. Not sure when but I hope soon. When are you planing to tag the next release? Also, I think I might change some strings. How are you dealing with new strings in languages that other contributors translated?

Neamar commented 6 years ago

You can change all the strings you want, and the translation system will pick it from there :)

Ideally, if you change the number of placeholders though ($1%s), use a new name, otherwise it gets messy.

Looking forward to your changes!