search

Neamar / teamward-client

Android client for Teamward app
https://play.google.com/store/apps/details?id=fr.neamar.lolgamedata
MIT License
16 stars 5 forks source link

Make notification icon white #29

Closed selcukXIII closed 6 years ago

selcukXIII commented 6 years ago

It is dark, it does not look good and hard to see on most scenarios.

Neamar commented 6 years ago

That's a good point. It's displayed white in every device after Lollipop, but older devices are not using the same API... I'll fix this with the next release, thanks!

selcukXIII commented 6 years ago

I'm on 7.0 and I'm using Samsung Galaxy S7. It is definitely black on my device.

On Sun, Dec 17, 2017, 19:48 Matthieu Bacconnier notifications@github.com wrote:

That's a good point. It's displayed white in every device after Lollipop, but older devices are not using the same API... I'll fix this with the next release, thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Neamar/teamward-client/issues/29#issuecomment-352268990, or mute the thread https://github.com/notifications/unsubscribe-auth/AHt_P3pnpwN1AHsEgTTED9BbERKBQmZFks5tBUXOgaJpZM4REpV3 .

--

Cheers! Mustafa Selçuk Öztürk

Neamar commented 6 years ago

Interesting, this is how it looks for me:

2017-12-17 18 03 12

Android adds a "tint" to the icon automatically since Lollipop, but I guess every OEM is free to pimp it then. I'll have an update with a white icon soon!

selcukXIII commented 6 years ago

That's how it looks on mine: https://photos.app.goo.gl/sPcIvXJUAG4CXuZg1

On Sun, Dec 17, 2017, 20:05 Matthieu Bacconnier notifications@github.com wrote:

Interesting, this is how it looks for me:

[image: 2017-12-17 18 03 12] https://user-images.githubusercontent.com/536844/34081865-51947518-e34c-11e7-87db-d72a88971a59.png

Android adds a "tint" to the icon automatically since Lollipop, but I guess every OEM is free to pimp it then. I'll have an update with a white icon soon!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Neamar/teamward-client/issues/29#issuecomment-352270038, or mute the thread https://github.com/notifications/unsubscribe-auth/AHt_P62bKrQKPZgXve4uCjbaYxsyrA7Dks5tBUn3gaJpZM4REpV3 .

--

Cheers! Mustafa Selçuk Öztürk

Neamar commented 6 years ago

That's ugly indeed, and small! I'm on it, thanks for the report

Neamar commented 6 years ago

Hey,

I'm pushing a new version to the Store. Join the beta, and download v2.17.2, it should fix your issue :)

selcukXIII commented 6 years ago

Just tested, it looks very good. Thanks for quick fix!