Near-One / near-plugins

Implementation of common patterns used for NEAR smart contracts.
Creative Commons Zero v1.0 Universal
27 stars 12 forks source link

feat: bump near-sdk to 5.1.0 #134

Closed mitinarseny closed 3 weeks ago

mooori commented 4 weeks ago

Strangely check Rust Contracts / Tests (pull_requests) was skipped after approving workflows to run, even though relevant files where changed since the last run. It didn't tell why so I just started it manually through Github's UI.

mooori commented 4 weeks ago

I missed 542009b was pushed while I was reviewing. Will have to take a look at that before enabling merge.

mooori commented 4 weeks ago

@mitinarseny what is the motivation for adding 542009b to this PR?

mitinarseny commented 4 weeks ago

I've just tried to use near-plugins in another project and it turns out that it doesn't let you use #[derive(AccessControlRole)], #[access_control], etc... without importing indirect trait dependencies into current scope:

use near_plugins::{access_control, AccessControlRole, AccessControllable, Ownable, Pausable};

#[derive(AccessControlRole, Clone, Copy)]
pub enum Role {
    // ...
}

#[access_control(role_type(Role))]
// #[derive(Ownable)], etc...
pub struct Contract {
    // ...
}

But I agree that it's not directly connected to "bumping near-sdk version". @mooori Do you think it would be better to fix it in a separate PR?

PS: I might need to rebase the whole branch to have my commits signed... Do you mind if I do it now and re-request your review? Sorry for that, didn't pay attention in the first place

image
karim-en commented 3 weeks ago

PS: I might need to rebase the whole branch to have my commits signed... Do you mind if I do it now and re-request your review? Sorry for that, didn't pay attention in the first place

I want to avoid the force push and re-review, so I've disabled this requirement.

mitinarseny commented 3 weeks ago

Thank you so much! @mooori @karim-en 🙏🏻 Waiting for merge from someone with write access

PS: Already set up everything related to commit signing, so wouldn't mess up in the next PR😅