Closed mooori closed 1 year ago
Makes pa_pause and pa_unpause return a bool that indicates whether the feature is newly (un)paused. This corresponds to the return values of std::collections::HashSet methods insert and remove.
pa_pause
pa_unpause
bool
std::collections::HashSet
Closes this external issue.
This PR also changes event emitting behavior. Sneaking it into this PR since it only reorders code in the two functions that are modified here.
Previously events Pause and Unpause were emitted even if:
Pause
Unpause
To avoid this, code that emits events has been moved past actions that may fail.
Makes
pa_pause
andpa_unpause
return abool
that indicates whether the feature is newly (un)paused. This corresponds to the return values ofstd::collections::HashSet
methods insert and remove.Closes this external issue.
Other changes: events
This PR also changes event emitting behavior. Sneaking it into this PR since it only reorders code in the two functions that are modified here.
Previously events
Pause
andUnpause
were emitted even if:To avoid this, code that emits events has been moved past actions that may fail.
Breaking changes
pa_pause
andpa_unpause
returnbool
(previously no return value).Pause
andUnpause
events are only emitted when state is successfully modified.