search

Near-One / rainbow-bridge

🌈🌈🌈 NEAR <> Ethereum Decentralized Bridge
GNU General Public License v3.0
327 stars 100 forks source link

RB should use borsh-js library instead of internal util. #438

Open volovyks opened 3 years ago

volovyks commented 3 years ago

Most of the code from borsh.js and some code from borshify-proof.js should be replaced with the use of Borsh-JS library.

chadoh commented 3 years ago

Thanks, @volovyk-s! I think most of the code that uses the borsh.js file will be replaced by the forthcoming rainbow-bridge-lib library, which will be extracted from https://github.com/near/rainbow-bridge-frontend. It probably makes sense to wait until after that to fully complete the transition to borsh-js.

volovyks commented 3 years ago

@mfornet @chadoh looks like borsh.js was moved to rainbow-bridge-lib and borshify-proof.js is still in rainbow-bridge-frontend. But they still don't use borsh-js project.

volovyks commented 3 years ago

Ok, so rainbow-bridge-lib appeared to be archived. @mfornet if borshify_proof.js is not an issue - feel free to close this issue.

mfornet commented 3 years ago

This is still an issue. rainbow-bridge-lib was moved into this repository, and borsh.js still exists. We should remove borsh implementation and use it as a dependency. Thanks for bringing this up.