Near-One / rainbow-bridge

🌈🌈🌈 NEAR <> Ethereum Decentralized Bridge
GNU General Public License v3.0
326 stars 99 forks source link

Warnings compiling solidity contracts #491

Closed mfornet closed 3 years ago

mfornet commented 3 years ago

Compilation of solidity contracts emits several warnings. To see this locally use:

cd contracts/eth/nearbridge
./dist.sh

Warnings

 Warning: Accessing non-existent property 'INVALID_ALT_NUMBER' of module exports inside circular dependency
dist/NearDecoder.full.sol:464:5: Warning: Function state mutability can be restricted to pure
    function decodeInitialValidators(Borsh.Data memory data) internal view returns(InitialValidators memory validators) {
    ^ (Relevant source part starts here and spans across multiple lines).
KaiserKarel commented 3 years ago

I can check this out this weekend.

mfornet commented 3 years ago

Some warnings solved on #553