Near-One / rainbow-bridge

🌈🌈🌈 NEAR <> Ethereum Decentralized Bridge
GNU General Public License v3.0
327 stars 100 forks source link

AdminControlled: don't allow zero-address initialization #844

Open sept-en opened 2 years ago

sept-en commented 2 years ago

In PR#705, new functionality to nominate and accept admin was added. One of that parts was verifying that a zero address value for admin is not allowed for security measures. However, by default, the constructor allows initialization with zero address admin. This should be changed and disallowed. In case it's the expected behavior to have no admin, the deployer should use some other address (e.g., with all "1" digits).