ERC20Locker: make AdminControlled. Add tests.

Near-One / rainbow-token-connector

ERC-20/NEP-141 Token Connector for Rainbow Bridge

62 stars 18 forks source link

ERC20Locker: make AdminControlled. Add tests. #36

Closed sept-en closed 3 years ago

sept-en commented 3 years ago

Add AdminControlled contract.
ERC20Locker: inherit from AdminControlled.
ERC20Locker: make lockToken and unlockToken pausable.
Add tests.

mfornet commented 3 years ago

@sept-en https://github.com/near/rainbow-bridge/pull/496 is already merged. We can use Admin Controller as dependency now!

alexauroradev commented 3 years ago

Why tests are not triggered in buildkite, only building the contracts? @sept-en @mfornet

sept-en commented 3 years ago

Why tests are not triggered in buildkite, only building the contracts? @sept-en @mfornet

Good point. I added both ETH and NEAR side tests to the CI.

However, now I notice that one of the tests for bridge-token-factory - test_near_token_transfer fails with the following error: Action #0: Smart contract panicked: panicked at 'Native NEP21 on Ethereum is disabled.', src/lib.rs:281:9) }'

I believe that this test will not pass until the #39 is merged. So I temporarily disabled this test.

mfornet commented 3 years ago

I believe that this test will not pass until the #39 is merged. So I temporarily disabled this test.

Actually we removed entirely the functionality for bridging native NEAR tokens to ethereum for now.