search

NearInfinityBrowser / NearInfinity

An Infinity Engine Browser and Editor
GNU Lesser General Public License v2.1
85 stars 37 forks source link

Sources should retain compatibility with JDK version specified in the README #115

Closed Argent77 closed 5 years ago

Argent77 commented 5 years ago

Readme specifies JDK 8 as minimum requirement.

The following code is currently causing a compile error:

[javac] src/org/infinity/gui/SortableTable.java:305: error: cannot find symbol
[javac]         res = Arrays.compare(arr1, arr2, SORTER);
[javac]                     ^
[javac]   symbol:   method compare(String[],String[],Comparator<String>)
[javac]   location: class Arrays

Arrays.compare was introduced by JDK 9.

Possible solutions:

  1. Re-implement Arrays.compare with JDK 8 compliant code.
  2. Adjust minimum requirements in the README.

Unless future implementations make heavy use of JDK 9+ features, I'd suggest to apply solution 1.

Mingun commented 5 years ago

Now I do not plan use Java 9 features, so I also prefer solution 1