search

NearInfinityBrowser / NearInfinity

An Infinity Engine Browser and Editor
https://github.com/NearInfinityBrowser/NearInfinity/wiki
GNU Lesser General Public License v2.1
87 stars 37 forks source link

Viewer for special PS:T resource "quests.ini" #119

Closed Mingun closed 4 years ago

Mingun commented 5 years ago

@lynxlynxlynx, as the owner of gemrb project, may be you can suggest what happens if the number of quests in the [init]/questcount ini-entry does not match what is written in the file? For example, if a questcount=100 and count of the entries are actually 125 -- would left 25 be ignored? Or if some of the records from the middle will miss (for example, file contains entries 0, 1, 10), how does the game react to this?

lynxlynxlynx commented 5 years ago

I don't know if Avenger reversed this or it was a guess/decision, but we take the count to be definitive and loop using it. So anything over would be ignored. It also doesn't look like we care if they are contiguous or not.

I suggest a less saturated highlight colour than cyan, as it stands out now in a bad sense.

PS: I'm not the owner. :)

Mingun commented 4 years ago

I don't know if Avenger reversed this or it was a guess/decision, but we take the count to be definitive and loop using it. So anything over would be ignored. It also doesn't look like we care if they are contiguous or not.

OK. Left investigation for better times and future PRs

I suggest a less saturated highlight colour than cyan, as it stands out now in a bad sense.

Mmmm… As I see, cyan now used for highlight current selected line in the RSyntaxTextArea and I already used it in the other places. So now I prefer leave it as is. Of course, it is better will be take in account current color schema, but I do not know, how :)… And this will require reworking in all places, not just here, so yet another future PR

PS: I'm not the owner. :)

OK. :) But you are the most active contributor so I assumed you were aware of many of the IE internals nyans