search

NearInfinityBrowser / NearInfinity

An Infinity Engine Browser and Editor
https://github.com/NearInfinityBrowser/NearInfinity/wiki
GNU Lesser General Public License v2.1
87 stars 37 forks source link

New file type: OGG #20

Closed Argent77 closed 11 years ago

Argent77 commented 11 years ago

OGG files are labeled as ACM or WAV.

FredrikLindgren commented 11 years ago

This issue can be closed when NI no longer throws an exception on OGG files. For full support, refer to issue #32 .

Argent77 commented 11 years ago

The 3rd party Java package JOrbis adds native Ogg Vorbis decoding support. It's licensed under LGPL.

What do you think about adding the package to this project?

Edit: Alternatively, we could simply provide an export button, so the user can play it back in his/her audio player of choice.

FredrikLindgren commented 11 years ago

I looked a little at JOrbis a while back. Maybe I overlooked something, but it did not look like much of a library. Apparently you have to do your OGG comprehension yourself. I haven't looked at it at all, but from the description, J-Ogg may be an option. Edit: J-Ogg is possibly old and unmaintained.

Only providing an export option doesn't really work. Aside from the music, which really needs MUS comprehension, there are the eleventy million short voice clips. Having to play the sounds in an external player would be inconvenient to say the least.

Argent77 commented 11 years ago

This library may be another alternative. It requires Java 7, however.

Argent77 commented 11 years ago

Added Ogg Vorbis support and native ACM support. Added simplified audio resource system, cleaned up InfinityAmp, updated MUS resource class and Mass Exporter to reflect the changes.

The old sound classes have been deprecated and can be safely removed after dropping NWN/KOTOR support. References to the external audio conversion tools can be removed as well after dropping NWN/KOTOR support.

Retained IMA ADPCM support for now, but I suppose it's only used in NWN or KOTOR if at all (BG/BG2 and IWD/IWD2 don't support IMA ADPCM wave files).

Commit: https://github.com/Argent77/NearInfinity/commit/582b2371f5dde92394c28422c793b3e5a73eb4dc

Note: The threading code of the MUSResource class caused some trouble. Please give a notice if you still experience some weird GUI behavior in the MUS viewer (e.g. an occasional empty soundtrack list).

FredrikLindgren commented 11 years ago

The audio decoder GUI stuff can be removed now. ACM is not used by NWN or KotOR. Unless the old sound classes are still hooked up, they can be removed as well.

Argent77 commented 11 years ago

The audio decoder GUI stuff can be removed now.

Done. Old MUS classes have been dropped as well We have to keep the old sound classes however, until NWN/KotOR support has been dropped.