search

NearSocial / VM

Near Social VM
The Unlicense
36 stars 58 forks source link

Fix call split on element is not a string #166

Closed hsiaosiyuan0 closed 9 months ago

hsiaosiyuan0 commented 9 months ago

Hi,

this CL can fix this issue https://github.com/NearSocial/VM/issues/146, only one line involved

hsiaosiyuan0 commented 9 months ago

@evgenykuzyakov could you please take a review for this CL

matiasberaldo commented 9 months ago

I think the if condition should be like the one below, otherwise falsy values will pass through: !element || typeof element !== "string"

hsiaosiyuan0 commented 9 months ago

I think the if condition should be like the one below, otherwise falsy values will pass through: !element || typeof element !== "string"

do you have any actual falsy value for a example? it does not exists in my thread, however if there were, it passes through the previous logic as how it had been processed before.

hsiaosiyuan0 commented 9 months ago

close it to save time