search

Nebo15 / ecto_mnesia

Ecto adapter for Mnesia Erlang term database.
https://hex.pm/packages/ecto_mnesia
MIT License
243 stars 41 forks source link

update ecto #57

Open julien-leclercq opened 6 years ago

AndrewDryga commented 6 years ago

Hello, @julien-leclercq! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

AndrewDryga commented 6 years ago

@julien-leclercq Nice try :). But updating Ecto like that doesn't work for adapters, there were some breaking changes in query planning so to update adapter to the latest Ecto we will need to put more work into it.

AndrewDryga commented 6 years ago

Here is PR that explains what was changed: https://github.com/elixir-ecto/ecto/pull/2155

julien-leclercq commented 6 years ago

haha thanks for the quick answer and the welcoming message. Have you tried to implement it ? Does it look like a complicated task for someone just getting on board on this project ?

julien-leclercq commented 6 years ago

Do we want to remain backward compatible ?

AndrewDryga commented 6 years ago

@julien-leclercq we should keep backwards compatibility (the PR above explains how we can archive it). I've spent about an hour looking how to update Ecto, it should be relatively easy but eventually decided to wait for Ecto 3.0 to adapt to all the changes in one hop.

If you have time to work on it, I would be super-happy to help you along the way 👍.

julien-leclercq commented 6 years ago

sorry, I tried to look at it but I think my ecto knowledge is to thin at the moment for me to help, I am struggling understand what is to be changed. :(

AndrewDryga commented 6 years ago

No worries. I think @beardedeagle already works on this one, so we may see support pretty soon. Anyways I'll support Ecto 3.0 when it's out.

julien-leclercq commented 6 years ago

would you have advice on where to start to dive in ecto mecanisms understanding ?

AndrewDryga commented 6 years ago

@julien-leclercq it depends on what goals do you have, if you just want to learn how to use it - better build some apps with it. If you want to know internals - try contributing and make an adapter (contribution is easier because there is a lot of maintainers that would guide you).