Fix Elixir/dialyzer warnings

Nebo15 / ecto_mnesia

Ecto adapter for Mnesia Erlang term database.

https://hex.pm/packages/ecto_mnesia

MIT License

243 stars 41 forks source link

Fix Elixir/dialyzer warnings #74

Closed jonnystorm closed 5 years ago

jonnystorm commented 5 years ago

Fix "Collectable deprecated for non-empty lists" warnings
Fix erroneous node_not_running matches in Migrator
Fix typo in Migrator.reduce_fields/4 if statement
Remove erroneous error match in Table._insert/2

AndrewDryga commented 5 years ago

Hello, @jonnystorm! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

AndrewDryga commented 5 years ago

Ebert has finished reviewing this Pull Request and has found:

22 possible new issues (including those that may have been commented here).

You can see more details about this review at https://ebertapp.io/github/Nebo15/ecto_mnesia/pulls/74.

coveralls commented 5 years ago

Coverage decreased (-0.5%) to 88.267% when pulling 9007b3ac6f36d53a3f36168d90353138e22b16cd on jonnystorm:fix-warnings into de6ef5f991e838fa2a11d706b9791f451231ce7f on Nebo15:master.

AndrewDryga commented 5 years ago

Great job! 👍