Nebo15 / logger_json

JSON logger formatter with support for Google Cloud, DataDog and other for Elixir.
https://nebo15.github.io/logger_json/
MIT License
237 stars 92 forks source link

Make pretty JSON formatting optional in basic formatter #114

Closed hkrutzer closed 5 months ago

hkrutzer commented 5 months ago

Some log processors can't process JSON logs if they are spread across multiple lines.

I saw the other formatters don't have pretty at all so I'm not sure if it's intentional.

AndrewDryga commented 5 months ago

@hkrutzer Good catch! Please instead of making it an option just remove it. This is just a leftover after a total rewrite.

hkrutzer commented 5 months ago

Thanks, removed it!

AndrewDryga commented 5 months ago

Thank you! @hkrutzer

hkrutzer commented 5 months ago

Thanks @AndrewDryga. Are you planning on publishing 6.x to hex.pm anytime soon?

AndrewDryga commented 5 months ago

@hkrutzer yes, I'm just trying to test it in our production to make sure it won't fail in yours. I think I will bump the version early next week.