search

Nebo15 / logger_json

JSON logger formatter with support for Google Cloud, DataDog and other for Elixir.
https://nebo15.github.io/logger_json/
MIT License
242 stars 94 forks source link

Compatibility with Elixir v1.15 #115

Closed kbredemeier closed 6 months ago

kbredemeier commented 6 months ago

Hi there, I was just trying to use the latest RC in a project with elixir v1.15 and ran into a bit of a problem. Not sure if you intended to make this compatible with elixir 1.15 but apparently I am not the only one trying to do this.

AndrewDryga commented 6 months ago

Hey @kbredemeier, we can give it a try but I think we should require at least https://github.com/elixir-lang/elixir/releases/tag/v1.15.1 so that important Logger fixes are already there. Can you please update the version spec to something like ~> 1.16 or ~> 1.15.1? And add it to the CI matrix too.

The issue you linked was about rewriting everything because previously we had a full-blown logger back-end that was copied from some ancient Elixir version, and Elixir 1.15 allowed to finally get rid off it :).

kbredemeier commented 6 months ago

At least the title was refering to v1.15 :sweat_smile: Sure thing, changed the version to v1.15.1 and updated the CI matrix.