Always return :ok even if nothing is logged

Nebo15 / logger_json

JSON logger formatter with support for Google Cloud, DataDog and other for Elixir.

https://nebo15.github.io/logger_json/

MIT License

237 stars 92 forks source link

Always return :ok even if nothing is logged #126

Closed adamu closed 2 months ago

adamu commented 2 months ago

Make the return type of telemetry_logging_handler conform to its spec.

Currently, if the if level = level(level, conn) condition fails, the function returns nil, not :ok as specified.

AndrewDryga commented 2 months ago

@adamu thank you! Can you please add a test to make sure this case is covered too? Other than that LGTM.

coveralls commented 2 months ago

coverage: 100.0%. remained the same when pulling b6a31b8cd07c87000612402efbdf1274df2c7966 on adamu:ok into cad59792e2ce06d489ce3e7a526f55b4a1fd05ab on Nebo15:master.

adamu commented 2 months ago

@AndrewDryga added!